RE: [RFC PATCH V2 06/18] x86/hyperv: Use vmmcall to implement hvcall in sev-snp enlightened guest

From: Dexuan Cui <decui@microsoft.com>
To: Tianyu Lan <ltykernel@gmail.com>,
	"luto@kernel.org" <luto@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"jgross@suse.com" <jgross@suse.com>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>,
	"kirill@shutemov.name" <kirill@shutemov.name>,
	"jiangshan.ljs@antgroup.com" <jiangshan.ljs@antgroup.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"ashish.kalra@amd.com" <ashish.kalra@amd.com>,
	"srutherford@google.com" <srutherford@google.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"anshuman.khandual@arm.com" <anshuman.khandual@arm.com>,
	"pawan.kumar.gupta@linux.intel.com" 
	<pawan.kumar.gupta@linux.intel.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
	"alexander.shishkin@linux.intel.com" 
	<alexander.shishkin@linux.intel.com>,
	"sandipan.das@amd.com" <sandipan.das@amd.com>,
	"ray.huang@amd.com" <ray.huang@amd.com>,
	"brijesh.singh@amd.com" <brijesh.singh@amd.com>,
	"michael.roth@amd.com" <michael.roth@amd.com>,
	"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
	"venu.busireddy@oracle.com" <venu.busireddy@oracle.com>,
	"sterritt@google.com" <sterritt@google.com>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"samitolvanen@google.com" <samitolvanen@google.com>,
	"fenghua.yu@intel.com" <fenghua.yu@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: RE: [RFC PATCH V2 06/18] x86/hyperv: Use vmmcall to implement hvcall in sev-snp enlightened guest
Date: Mon, 9 Jan 2023 07:24:37 +0000	[thread overview]
Message-ID: <SA1PR21MB13354DDE24CC95A6690951B7BFFE9@SA1PR21MB1335.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20221119034633.1728632-7-ltykernel@gmail.com>

> From: Tianyu Lan <ltykernel@gmail.com>
> Sent: Friday, November 18, 2022 7:46 PM
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -45,16 +45,25 @@ static inline u64 hv_do_hypercall(u64 control, void
> *input, void *output)
>  	u64 hv_status;
> 
>  #ifdef CONFIG_X86_64
> -	if (!hv_hypercall_pg)
> -		return U64_MAX;
> +	if (hv_isolation_type_en_snp()) {
> +		__asm__ __volatile__("mov %4, %%r8\n"
> +				"vmmcall"
> +				: "=a" (hv_status), ASM_CALL_CONSTRAINT,
> +				"+c" (control), "+d" (input_address)
> +				:  "r" (output_address)
> +				: "cc", "memory", "r8", "r9", "r10", "r11");

Add a "return hv_status;" here to avoid chaning the indentation below?

> +	} else {
> +		if (!hv_hypercall_pg)
> +			return U64_MAX;
> 
> -	__asm__ __volatile__("mov %4, %%r8\n"
> -			     CALL_NOSPEC
> -			     : "=a" (hv_status), ASM_CALL_CONSTRAINT,
> -			       "+c" (control), "+d" (input_address)
> -			     :  "r" (output_address),
> -				THUNK_TARGET(hv_hypercall_pg)
> -			     : "cc", "memory", "r8", "r9", "r10", "r11");
> +		__asm__ __volatile__("mov %4, %%r8\n"
> +				CALL_NOSPEC
> +				: "=a" (hv_status), ASM_CALL_CONSTRAINT,
> +				"+c" (control), "+d" (input_address)
> +				:  "r" (output_address),
> +					THUNK_TARGET(hv_hypercall_pg)
> +				: "cc", "memory", "r8", "r9", "r10", "r11");
> +	}
>  #else