From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Terry Chen <terry_chen@wistron.corp-partner.google.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "Rojewski, Cezary" <cezary.rojewski@intel.com>,
"liam.r.girdwood@linux.intel.com"
<liam.r.girdwood@linux.intel.com>,
"yang.jie@linux.intel.com" <yang.jie@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"cujomalainey@chromium.org" <cujomalainey@chromium.org>,
"seanpaul@chromium.org" <seanpaul@chromium.org>,
"Bowman, Casey G" <casey.g.bowman@intel.com>,
"mark_hsieh@wistron.corp-partner.google.com"
<mark_hsieh@wistron.corp-partner.google.com>,
"Gopal, Vamshi Krishna" <vamshi.krishna.gopal@intel.com>,
"Chiang, Mac" <mac.chiang@intel.com>,
"kai.vehmanen@linux.intel.com" <kai.vehmanen@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] [v2] ASoC: Intel: sof_cs42l42: adding support for ADL configuration and BT offload audio
Date: Wed, 11 May 2022 06:49:24 +0000 [thread overview]
Message-ID: <SA2PR11MB4891CBFA1FAE454EC7620F0C97C89@SA2PR11MB4891.namprd11.prod.outlook.com> (raw)
In-Reply-To: <190c9add-7fa4-8e76-bfcb-43d30f22f8d9@linux.intel.com>
> > a/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> > b/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> > index 7c8cd00457f81..3f40519250a90 100644
> > --- a/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> > +++ b/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> > @@ -384,6 +384,14 @@ struct snd_soc_acpi_mach
> snd_soc_acpi_intel_adl_machines[] = {
> > .sof_fw_filename = "sof-adl.ri",
> > .sof_tplg_filename = "sof-adl-cs35l41.tplg",
> > },
> > + {
> > + .id = "10134242",
> > + .drv_name = "adl_mx98360a_cs4242",
> > + .machine_quirk = snd_soc_acpi_codec_list,
> > + .quirk_data = &adl_max98360a_amp,
> > + .sof_fw_filename = "sof-adl.ri",
>
> no longer necessary, and probably will not compile. please remove this field.
>
> > + .sof_tplg_filename = "sof-adl-max98360a-rt5682.tplg",
>
> Why would you refer to a topology that uses a different codec?
>
We asked cirrus logic to support bclk 2.4MHz, 50fs so all topologies for alc5682 could
be used directly.
Brent
next prev parent reply other threads:[~2022-05-11 6:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 10:48 [PATCH] [v2] ASoC: Intel: sof_cs42l42: adding support for ADL configuration and BT offload audio Terry Chen
2022-05-10 14:40 ` Pierre-Louis Bossart
2022-05-11 6:49 ` Lu, Brent [this message]
[not found] ` <CAMmR3bFad5ODKYUCg8Tp8GVk__AdaQHcpLnRmFyAGXu8Wpycog@mail.gmail.com>
2022-05-11 14:02 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA2PR11MB4891CBFA1FAE454EC7620F0C97C89@SA2PR11MB4891.namprd11.prod.outlook.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=casey.g.bowman@intel.com \
--cc=cezary.rojewski@intel.com \
--cc=cujomalainey@chromium.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=mark_hsieh@wistron.corp-partner.google.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=seanpaul@chromium.org \
--cc=terry_chen@wistron.corp-partner.google.com \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).