RE: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.

From: "R, Monish Kumar" <monish.kumar.r@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "olebowle@gmx.com" <olebowle@gmx.com>,
	"oneukum@suse.com" <oneukum@suse.com>,
	"vpalatin@chromium.org" <vpalatin@chromium.org>,
	"wangjm221@gmail.com" <wangjm221@gmail.com>,
	"chris.chiu@canonical.com" <chris.chiu@canonical.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Rao, Abhijeet" <abhijeet.rao@intel.com>
Subject: RE: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
Date: Fri, 6 May 2022 05:28:36 +0000	[thread overview]
Message-ID: <SA2PR11MB51157FBE0367288DEBC4396BC3C59@SA2PR11MB5115.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YnPARed/HKdnwPKV@kroah.com>

Hi greg,

Are you sure you need both?  How was this tested that both are actually set?

>>  Yes, both NO_LPM and RESET_RESUME quirks were needed.
As the Dell usb gen2 device U1/U2 link states were failing when connected to type-C ports.
Disabling LPM helps to resolve U1/U2 link state failures. However, it leads to resetting the device multiple times. So, added with NO_LPM and RESET_RESUME usb quirks.

Tested multiple hotplug of Dell usb gen 2 device, it passed for all the cases.

Regards,
Monish Kumar R

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org> 
Sent: 05 May 2022 17:47
To: R, Monish Kumar <monish.kumar.r@intel.com>
Cc: olebowle@gmx.com; oneukum@suse.com; vpalatin@chromium.org; wangjm221@gmail.com; chris.chiu@canonical.com; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Rao, Abhijeet <abhijeet.rao@intel.com>
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.

On Thu, May 05, 2022 at 03:44:59PM +0530, monish.kumar.r@intel.com wrote:
> From: Monish Kumar R <monish.kumar.r@intel.com>
> 
> Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c 
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id 
> usb_quirk_list[] = {
>  
>  	/* INTEL VALUE SSD */
>  	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME 
> },
>         
> +	/*DELL USB GEN2 */
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME 
> +},

Are you sure you need both?  How was this tested that both are actually set?

thanks,

greg k-h