From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932221AbcFIKtY (ORCPT ); Thu, 9 Jun 2016 06:49:24 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:19871 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932143AbcFIKtV convert rfc822-to-8bit (ORCPT ); Thu, 9 Jun 2016 06:49:21 -0400 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'208";a="213104820" From: Yoshihiro Shimoda To: Roger Quadros , "peter.chen@freescale.com" CC: "balbi@kernel.org" , "tony@atomide.com" , "gregkh@linuxfoundation.org" , "dan.j.williams@intel.com" , "mathias.nyman@linux.intel.com" , "Joao.Pinto@synopsys.com" , "sergei.shtylyov@cogentembedded.com" , "jun.li@freescale.com" , "grygorii.strashko@ti.com" , "robh@kernel.org" , "nsekhar@ti.com" , "b-liu@ti.com" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [PATCH v9 13/14] usb: gadget: udc: adapt to OTG core Thread-Topic: [PATCH v9 13/14] usb: gadget: udc: adapt to OTG core Thread-Index: AQHRwWU4FWL4MR6pNECdwOmffmBr9J/g8oFg Date: Thu, 9 Jun 2016 10:49:13 +0000 Message-ID: References: <1465376626-30122-1-git-send-email-rogerq@ti.com> <1465376626-30122-14-git-send-email-rogerq@ti.com> In-Reply-To: <1465376626-30122-14-git-send-email-rogerq@ti.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.144] x-ms-office365-filtering-correlation-id: c3019137-f390-4432-a48a-08d39053b201 x-microsoft-exchange-diagnostics: 1;SG2PR06MB0917;5:TKMQoCuFrQMU4lcyEUnJaPQylFnlEViA9OZCmqQkPcjq8oUP1viqDzRp+VLVW7RvrcHz2j4FJbj+wH7f7vnwN5+4zb/H/BBGnPVaungXAKophSxDJR7gq/FdjiIWeU4epem3aR2VvIy6nMBRheE1eA==;24:LWDjSKjFFmeGohfDyVNVhmbqW3knGwNE2GiToHKYLVJ+R69I37zLnVTXuS+wjG5gyRs2cYDnx6waoYYGq55HDulN5wwObaWOt8TWXInDGCI=;7:tbnq33qDQA02jIgqfohQoNx2G0yD3Lp+YJrX285k8j1XMjVYnDPKMrCEFpVc7HaHkexbIcCbPk+4aRTaaBtvCv/2M/RzI/gEqs+iXYEKfADURn1tgeKvMy1iap+obJy68XcheEeVm7OjxezY2SbbfaF/PpJtwjIb3y+kW8dASK1/re70sA7AUgQAZb3MNc5nvVVHMWY8DoTZ4kmdbaoyHJINlFoha1PPMf2nX1zgSUk=;20:73/eu0Vo89oz117WpX13BWNGSCaH54/yZZ90rDvnNugB33vr9UwZlBT0cqR6Tat63zP2w67d2QolDStcc55RhsLzkBxJ4l0HxW1Jx60V5I8qSnqO2oNsWVKojOf8MvNECE1bB95aNRuPdz3j52W51yGlCq4CSU36NhOHmvcl98I= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0917; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(31051911155226)(84791874153150)(21532816269658); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:SG2PR06MB0917;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0917; x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(377454003)(68736007)(5008740100001)(2906002)(11100500001)(10400500002)(5001770100001)(3280700002)(101416001)(2501003)(92566002)(8936002)(106116001)(97736004)(6116002)(33656002)(86362001)(5004730100002)(76576001)(122556002)(4326007)(3846002)(102836003)(106356001)(74316001)(5002640100001)(54356999)(15975445007)(105586002)(77096005)(586003)(76176999)(50986999)(3660700001)(19580395003)(5003600100002)(189998001)(19580405001)(87936001)(81166006)(2900100001)(8666004)(8676002)(66066001)(81156014)(2950100001)(9686002)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB0917;H:SG2PR06MB0919.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2016 10:49:13.1571 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB0917 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, > From: Roger Quadros > Sent: Wednesday, June 08, 2016 6:04 PM > > The OTG state machine needs a mechanism to start and > stop the gadget controller as well as connect/disconnect > from the bus. Add usb_gadget_start(), usb_gadget_stop() > and usb_gadget_connect_control(). > > Introduce usb_otg_add_gadget_udc() to allow controller drivers > to register a gadget controller that is part of an OTG instance. > > Register with OTG core when UDC is added in usb_add_gadget_udc_release() > and unregister on usb_del_gadget_udc(). > > Notify the OTG core when gadget function driver is available on > udc_bind_to_driver() and when it is removed in usb_gadget_remove_driver(). > > We need to unlock the usb_lock mutex before calling > usb_otg_register_gadget() else it will cause a circular > locking dependency. > > Ignore softconnect sysfs control when we're in OTG > mode as OTG FSM should care of gadget softconnect using > the b_bus_req mechanism. > > Signed-off-by: Roger Quadros > --- > drivers/usb/gadget/udc/udc-core.c | 202 ++++++++++++++++++++++++++++++++++++-- > include/linux/usb/gadget.h | 4 + > 2 files changed, 196 insertions(+), 10 deletions(-) I tried to apply this patch on the Felipe's usb.git / testing/next branch, but I couldn't apply because the udc-core.c was renamed to core.c. https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=a22b539c7082b6a3046b3a9cebb356a047a2d81d I guess this patch needs rebase for that. Best regards, Yoshihiro Shimoda