From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965809AbcJ0OIx (ORCPT ); Thu, 27 Oct 2016 10:08:53 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:19580 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030397AbcJ0OIo (ORCPT ); Thu, 27 Oct 2016 10:08:44 -0400 X-IronPort-AV: E=Sophos;i="5.31,404,1473087600"; d="scan'208";a="223535425" From: Ramesh Shanmugasundaram To: Mark Brown CC: "mattw@codeaurora.org" , "mitchelh@codeaurora.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Chris Paterson Subject: RE: [PATCH 2/2] regmap: Avoid namespace collision within macro Thread-Topic: [PATCH 2/2] regmap: Avoid namespace collision within macro Thread-Index: AQHSMDZiO2zc79c47Uq+SOg5rMfvf6C8FbuAgAAAS9A= Date: Thu, 27 Oct 2016 10:22:01 +0000 Message-ID: References: <1477560799-58896-1-git-send-email-ramesh.shanmugasundaram@bp.renesas.com> <1477560799-58896-3-git-send-email-ramesh.shanmugasundaram@bp.renesas.com> <20161027101545.GH25322@sirena.org.uk> In-Reply-To: <20161027101545.GH25322@sirena.org.uk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ramesh.shanmugasundaram@bp.renesas.com; x-originating-ip: [193.141.220.21] x-ms-office365-filtering-correlation-id: 81ff5c40-f2f7-4c81-092e-08d3fe53178f x-microsoft-exchange-diagnostics: 1;KL1PR0601MB1336;7:FEwYhPN+a6yilun+Y75qDWBSb1UdajhO/S3FSqOREYXGMYfx6gT38kjEZ6KqmewRYyk0dVQzzHUTYDnwAY2tSKuMJd1Fd/H5tWrOcPpuc53ukenF+yW/4Ra0Lh+XWHPFb9I0YVQHSny+0yuxv7jons+3mYyU3hDDs1/jTAJetsmxG6QACaHFa2Mq+k6tpKfjw/SZ4Oc8fanC3iJYP6IYmFsKemQu0c/49Sxn3PkaxJCX7p2DwSn0bEE3fSNwsA/GkBwyy5kXIxC0zPz54T3oG2T3jl1BowJlF5BislHuMdbD2Zvof1c/ex+rxljlk1JuB2q5FayKQPF1kWXHQr1tWFCyDlzf6yMpv21kE/x081s=;20:H3nL7E2DY1zA1VpJ3IvKtseD2x3OIq7hG0kMifb0pVr81J+2P9UC8z0WBF+FpOvbeQLc/pM1CCqGbBJ6zQ71vFCZqvQUs/kmyJwzq/dFMH1LMzeV9zsaQDaoJg63k7Zd/fyjlaSEEe2NjfaoXGO+v0Pvu0rprBRa3JYLPaAlGfg= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:KL1PR0601MB1336; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:KL1PR0601MB1336;BCL:0;PCL:0;RULEID:;SRVR:KL1PR0601MB1336; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(7916002)(199003)(24454002)(189002)(6116002)(106356001)(87936001)(33656002)(6916009)(81156014)(68736007)(105586002)(86362001)(102836003)(50986999)(54356999)(586003)(42882006)(9686002)(101416001)(2950100002)(3846002)(76176999)(4001430100002)(106116001)(76576001)(8936002)(66066001)(107886002)(189998001)(2900100001)(92566002)(97736004)(305945005)(7736002)(7846002)(5002640100001)(74316002)(4326007)(3660700001)(81166006)(3280700002)(7696004)(5250100002)(8676002)(11100500001)(110136003)(2906002)(5660300001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1PR0601MB1336;H:SG2PR06MB1038.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2016 10:22:01.8791 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1336 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9REA4F1007262 > On Thu, Oct 27, 2016 at 10:33:19AM +0100, Ramesh Shanmugasundaram wrote: > > > #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us, > > timeout_us) \ ({ \ > > - ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \ > > + ktime_t __timeout = ktime_add_us(ktime_get(), timeout_us); \ > > int ret; \ > > Why is timeout an issue and not ret? It is! However, it is less likely for someone to use "ret" as a variable name for the given parameter list. Hence, I fixed timeout alone. Feel free to fix "ret" as well. Thanks, Ramesh