From: Chris Brandt <Chris.Brandt@renesas.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>
Cc: "linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/7] Renesas RZ/A1 pin and gpio controller
Date: Wed, 22 Mar 2017 18:10:26 +0000 [thread overview]
Message-ID: <SG2PR06MB1165AB3D48DA3450FC27EA3D8A3C0@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org>
Hi Jacopo,
On Monday, March 20, 2017, Jacopo Mondi wrote:
> Chris: it would be great if you could give this another spin on RSK board.
I tested these patches on an RZ/A1H RSK board after modifying the DT for
the RSK vs the GENMAI board.
The following worked fine:
* SCIF
* I2C
* SDHI
* Ethernet
I see Geert has already responded with mostly text (grammar) changes.
As for the "API" of the driver from a user perspective, I think it should
cover all the use cases of the peripherals.
For your reference, here was my pin config for the RSK board testing. Once
this driver is (hopefully) accepted, I will update the upstream rskrza1 DT.
--- RSK BOARD PIN SETUP ---
&pinctrl {
scif2_pins: serial2 {
/* P3_0 as TxD2; P3_2 as RxD2 */
renesas,pins = <PIN(3, 0) 6>,
<PIN(3, 2) 4>;
};
/* RIIC Ch 3 */
i2c3_pins: i2c3 {
/* RIIC3: P1_6 as SCL, P1_7 as SDA */
renesas,pins = <PIN(1, 6) (1 | BI_DIR)>,
<PIN(1, 7) (1 | BI_DIR)>;
};
/* SHDI ch1 on CN1 */
sdhi1_pins: sdhi1 {
/* SHDI ch1 on Port 3 */
renesas,pins = <PIN(3, 8) (7)>, /* SDHI1 CD */
<PIN(3, 9) (7)>, /* SDHI1 WP */
<PIN(3, 10) (7 | BI_DIR)>, /* SDHI1 DAT1 */
<PIN(3, 11) (7 | BI_DIR)>, /* SDHI1 DAT0 */
<PIN(3, 12) (7)>, /* SDHI1 CLK */
<PIN(3, 13) (7 | BI_DIR)>, /* SDHI1 CMD */
<PIN(3, 14) (7 | BI_DIR)>, /* SDHI1 DAT3 */
<PIN(3, 15) (7 | BI_DIR)>; /* SDHI1 DAT2 */
};
/* Ethernet */
ether_pins: ether {
/* Ethernet on Ports 1,2,3,5 */
renesas,pins = <PIN(1, 14) (4)>, /* P1_14 = ET_COL */
<PIN(5, 9) (2)>, /* P5_9 = ET_MDC */
<PIN(3, 3) (2 | BI_DIR)>, /* P3_3 = ET_MDIO (bi dir) */
<PIN(3, 4) (2)>, /* P3_4 = ET_RXCLK */
<PIN(3, 5) (2)>, /* P3_5 = ET_RXER */
<PIN(3, 6) (2)>, /* P3_6 = ET_RXDV */
<PIN(2, 0) (2)>, /* P2_0 = ET_TXCLK */
<PIN(2, 1) (2)>, /* P2_1 = ET_TXER */
<PIN(2, 2) (2)>, /* P2_2 = ET_TXEN */
<PIN(2, 3) (2)>, /* P2_3 = ET_CRS */
<PIN(2, 4) (2)>, /* P2_4 = ET_TXD0 */
<PIN(2, 5) (2)>, /* P2_5 = ET_TXD1 */
<PIN(2, 6) (2)>, /* P2_6 = ET_TXD2 */
<PIN(2, 7) (2)>, /* P2_7 = ET_TXD3 */
<PIN(2, 8) (2)>, /* P2_8 = ET_RXD0 */
<PIN(2, 9) (2)>, /* P2_9 = ET_RXD1 */
<PIN(2, 10) (2)>, /* P2_10 = ET_RXD2 */
<PIN(2, 11) (2)>; /* P2_11 = ET_RXD3 */
};
};
&i2c3 {
pinctrl-names = "default";
pinctrl-0 = <&i2c3_pins>;
};
&scif2 {
pinctrl-names = "default";
pinctrl-0 = <&scif2_pins>;
};
&sdhi1 {
pinctrl-names = "default";
pinctrl-0 = <&sdhi1_pins>;
};
ðer {
pinctrl-names = "default";
pinctrl-0 = <ðer_pins>;
};
/ {
leds {
status = "okay";
compatible = "gpio-leds";
led1 {
gpios = <&port7 1 GPIO_ACTIVE_LOW>;
};
};
};
Thank you,
Chris
prev parent reply other threads:[~2017-03-22 18:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 16:14 [PATCH v2 0/7] Renesas RZ/A1 pin and gpio controller Jacopo Mondi
2017-03-20 16:14 ` [PATCH v2 1/7] pinctrl: " Jacopo Mondi
2017-03-22 10:26 ` Geert Uytterhoeven
2017-03-23 14:19 ` jacopo
2017-03-20 16:14 ` [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Jacopo Mondi
2017-03-22 10:33 ` Geert Uytterhoeven
2017-03-22 13:20 ` Geert Uytterhoeven
2017-03-22 15:36 ` jacopo
2017-03-22 15:49 ` Geert Uytterhoeven
2017-03-23 16:02 ` jacopo
2017-03-28 9:46 ` Linus Walleij
2017-03-28 14:38 ` jacopo
2017-03-29 2:30 ` Linus Walleij
2017-03-29 7:35 ` Geert Uytterhoeven
2017-03-29 10:15 ` Linus Walleij
2017-03-29 11:20 ` Geert Uytterhoeven
2017-03-29 12:05 ` jacopo
2017-03-29 12:38 ` Chris Brandt
2017-03-29 13:10 ` Linus Walleij
2017-03-29 14:09 ` Chris Brandt
2017-03-29 13:04 ` Linus Walleij
2017-03-20 16:14 ` [PATCH v2 3/7] arm: dts: dt-bindings: Add Renesas RZ pinctrl header Jacopo Mondi
2017-03-22 10:35 ` Geert Uytterhoeven
2017-03-20 16:14 ` [PATCH v2 4/7] arm: dts: r7s72100: Add pin controller node Jacopo Mondi
2017-03-22 13:12 ` Geert Uytterhoeven
2017-03-23 16:13 ` jacopo
2017-03-20 16:14 ` [PATCH v2 5/7] arm: dts: genmai: Add SCIF2 pin group Jacopo Mondi
2017-03-22 13:13 ` Geert Uytterhoeven
2017-03-20 16:14 ` [PATCH v2 6/7] arm: dts: genmai: Add RIIC2 " Jacopo Mondi
2017-03-22 13:17 ` Geert Uytterhoeven
2017-03-20 16:14 ` [PATCH v2 7/7] arm: dts: genmai: Add user led device nodes Jacopo Mondi
2017-03-22 13:23 ` Geert Uytterhoeven
2017-03-22 18:10 ` Chris Brandt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SG2PR06MB1165AB3D48DA3450FC27EA3D8A3C0@SG2PR06MB1165.apcprd06.prod.outlook.com \
--to=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).