From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756326AbdELM5f (ORCPT ); Fri, 12 May 2017 08:57:35 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:62181 "EHLO relmlie4.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755171AbdELM5c (ORCPT ); Fri, 12 May 2017 08:57:32 -0400 X-IronPort-AV: E=Sophos;i="5.38,329,1491231600"; d="scan'208";a="243590365" From: Chris Brandt To: Geert Uytterhoeven CC: Linus Walleij , jmondi , "Andy Shevchenko" , Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Rob Herring , Mark Rutland , "Russell King - ARM Linux" , Linux-Renesas , "linux-gpio@vger.kernel.org" , devicetree , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable Thread-Topic: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable Thread-Index: AQHSvy8kW/T8jbNXV0G/jE8WsCEqd6HZTneAgAEnEICAACrhkIAAE36AgAAKEjCAACHsAIANr5WAgAIa0gCAAAIDAIAAFXEAgABBdACAAOPPAIAEmDaAgAAjhgCAAAkCUIAAC4mAgAAINQA= Date: Fri, 12 May 2017 12:57:27 +0000 Message-ID: References: <1493281194-5200-2-git-send-email-jacopo+renesas@jmondi.org> <20170508160120.GB25206@w540> <20170508172516.GC25206@w540> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux-m68k.org; dkim=none (message not signed) header.d=none;linux-m68k.org; dmarc=none action=none header.from=renesas.com; x-originating-ip: [75.60.247.61] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;SG2PR06MB1167;7:/596DCOnEpldWzqUc9R7zYPrXgx3L1jiBPaPYOHKVSxcQFNzHHAqhVUdMtGc0hBnZIWq2ZgcoLfa8quLY1LmjMWGGPQ7MxpA0rJKx8wxHUeowkUAMkGu4M0wOSwHiCHNm1jJfaG1m7MEXwK9NcNxvT4j+eVfjST8A48wUIm43UouzZsaILavOAph2uGFcyn/SW673v1U+oxQvMH5s6T6vfNzLziuR4EVSMsir+QqYxxahu92TloVyNtVDTXkksOMgTj9YVQTzG5X1k8NDWEqzV88SvsonMaNQSWaZOtxZGsr5Svl9eQhMLGg9Plzm5ftIrp+bvCoyNJ4vCEfOIntCQ==;20:m+cjLidNMjSLfeL78ThCyYMMkCGCByd+SWPBJCXMUo3Ogy2E+5bmQNIhoPwYzkuXDNkIUyP7bH+rjnsNeX4ORDkxFhjfdegAro88NQO4le+3KeZPMygPxAPiDyYVL6lN6bBCbzse1PnyA202UOGErJ1Y6p4l6ZOBmaRS+4tWmRY= x-ms-office365-filtering-correlation-id: d7226a1c-a327-453f-b8f7-08d499367131 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:SG2PR06MB1167; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148);SRVR:SG2PR06MB1167;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1167; x-forefront-prvs: 0305463112 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39840400002)(39400400002)(39850400002)(39860400002)(39410400002)(39450400003)(24454002)(305945005)(38730400002)(110136004)(2906002)(6506006)(4326008)(77096006)(7736002)(189998001)(3660700001)(53936002)(39060400002)(6436002)(3846002)(3280700002)(99286003)(54906002)(6116002)(55016002)(54356999)(76176999)(50986999)(9686003)(102836003)(6246003)(7416002)(8936002)(2950100002)(6916009)(122556002)(2900100001)(5660300001)(7696004)(66066001)(86362001)(74316002)(33656002)(72206003)(478600001)(25786009)(229853002)(93886004)(8676002)(81166006)(41533002);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB1167;H:SG2PR06MB1165.apcprd06.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2017 12:57:27.0368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1167 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4CCwXcj027050 Hi Geert, On Friday, May 12, 2017, Geert Uytterhoeven wrote: > 12 x 16 = 192, not 384. Opps, my math was off! (I think I need another cup of coffee this morning) > Do you need all possible combinations of input, output, and bi-dir? > I assumed they're mutually exclusive. If not, you need 3 bits/pin/function You're right, they are mutually exclusive, so 2 bits are fine. Also, the other pinout variations chips (RZ/A1L,A1LU,A1LC) only have 10 ports: 12 ports x 16 pins x 2bits-per-bit => 384 bytes 10 ports x 16 pins x 2bits-per-bit => 320 bytes 384 + 320 = 704 bytes (of const data) > With packages, do you mean e.g. RZ/A1H vs. RZ/A1L? Yes. > These indeed differ, > but > should use different compatible values. OK. Since r7s72100.dtsi has compatible = "renesas,r7s72100-ports"; We'll just override that in say my-rza1l-board.dts &pinctrl { compatible = "renesas,r7s72102-ports"; }; and then look for that in the driver. > Or do you mean QFP/BGA256 vs. BGA324? Isn't the former a subset of the > latter? The "package" doesn't matter, it's the pin assignments on the die: RZ/A1H = RZ/A1M = pin assignments #1 RZ/A1L = RZ/A1LU = RZ/A1LC = pin assignments #2 Then each of those parts above have multiple 'package options', but of course doesn't change the actual pin/function assignments (that's part of the silicon die) Chris