From: "Sajida Bhanu (Temp) (QUIC)" <quic_c_sbhanu@quicinc.com>
To: Pratyush Yadav <p.yadav@ti.com>,
"Sajida Bhanu (Temp) (QUIC)" <quic_c_sbhanu@quicinc.com>
Cc: "dianders@chromium.org" <dianders@chromium.org>,
"tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
"michael@walle.cc" <michael@walle.cc>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"richard@nod.at" <richard@nod.at>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stummala@codeaurora.org" <stummala@codeaurora.org>,
"vbadigan@codeaurora.org" <vbadigan@codeaurora.org>,
"Ram Prakash Gupta (QUIC)" <quic_rampraka@quicinc.com>,
"Pradeep Pragallapati (QUIC)" <quic_pragalla@quicinc.com>,
"sartgarg@codeaurora.org" <sartgarg@codeaurora.org>
Subject: RE: [PATCH V4] mtd: spi-nor: winbond: Add support for winbond chip
Date: Mon, 24 Jan 2022 07:31:01 +0000 [thread overview]
Message-ID: <SJ0PR02MB8449DDEE0A6F9146BFF3F265CD5E9@SJ0PR02MB8449.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20220120101221.oqtfa6vosnweqsoq@ti.com>
Hi,
Thanks for the review.
Please find the inline comments.
Thanks,
Sajida
-----Original Message-----
From: Pratyush Yadav <p.yadav@ti.com>
Sent: Thursday, January 20, 2022 3:42 PM
To: Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu@quicinc.com>
Cc: dianders@chromium.org; tudor.ambarus@microchip.com; michael@walle.cc; miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; stummala@codeaurora.org; vbadigan@codeaurora.org; Ram Prakash Gupta (QUIC) <quic_rampraka@quicinc.com>; Pradeep Pragallapati (QUIC) <quic_pragalla@quicinc.com>; sartgarg@codeaurora.org
Subject: Re: [PATCH V4] mtd: spi-nor: winbond: Add support for winbond chip
Hi,
On 20/01/22 03:24PM, Shaik Sajida Bhanu wrote:
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> ---
>
> Changes since V1:
> - Added space before name of the flash part as suggested by Doug.
>
> Changes since V2:
> - Updated chip name as w25q512nwm as suggested by Doug.
>
> Changes since V3:
> - Updated flash_info flags passing according to below patch
> https://lore.kernel.org/all/20211207140254.87681-7-tudor.ambarus@microchip.com/
> As suggested by Tudor Ambarus.
> ---
> drivers/mtd/spi-nor/winbond.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c index 675f32c..c4be225 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -124,6 +124,10 @@ static const struct flash_info winbond_parts[] = {
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
> + FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> + SPI_NOR_QUAD_READ) },
This way is for "legacy" flash code and is not recommended anymore. Does the flash support SFDP? In that case just add PARSE_SFDP and let the SFDP parser discover these capabilities. You can keep the "FLAGS" part since those are not discoverable via SFDP.
>>>>>>>Yes this flash supports SFDP, sure will pass PARSE_SFDP.
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> member of Code Aurora Forum, hosted by The Linux Foundation
>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2022-01-24 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 9:54 [PATCH V4] mtd: spi-nor: winbond: Add support for winbond chip Shaik Sajida Bhanu
2022-01-20 10:12 ` Pratyush Yadav
2022-01-24 7:31 ` Sajida Bhanu (Temp) (QUIC) [this message]
2022-01-20 10:31 ` Michael Walle
2022-01-25 15:36 ` Sajida Bhanu (Temp) (QUIC)
2022-01-25 15:52 ` Michael Walle
2022-01-28 6:37 ` Sajida Bhanu (Temp) (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR02MB8449DDEE0A6F9146BFF3F265CD5E9@SJ0PR02MB8449.namprd02.prod.outlook.com \
--to=quic_c_sbhanu@quicinc.com \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=richard@nod.at \
--cc=sartgarg@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=tudor.ambarus@microchip.com \
--cc=vbadigan@codeaurora.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).