From: Thomas Tai <thomas.tai@oracle.com>
To: "Luck, Tony" <tony.luck@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"reinette.chatre@intel.co" <reinette.chatre@intel.co>,
"naoya.horiguchi@nec.com" <naoya.horiguchi@nec.com>,
"linmiaohe@huawei.com" <linmiaohe@huawei.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory
Date: Tue, 27 Sep 2022 21:41:04 +0000 [thread overview]
Message-ID: <SJ0PR10MB46238985ADC07034B781A338FD559@SJ0PR10MB4623.namprd10.prod.outlook.com> (raw)
In-Reply-To: <SJ1PR11MB60836FCA1B8B317003CBF99FFC559@SJ1PR11MB6083.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Luck, Tony <tony.luck@intel.com>
> Sent: September 27, 2022 4:35 PM
> To: Thomas Tai <thomas.tai@oracle.com>; dave.hansen@linux.intel.com;
> jarkko@kernel.org; reinette.chatre@intel.co; naoya.horiguchi@nec.com;
> linmiaohe@huawei.com; akpm@linux-foundation.org; linux-mm@kvack.org;
> linux-kernel@vger.kernel.org; Thomas Tai <thomas.tai@oracle.com>
> Subject: RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory
>
> > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection
> > address validation), add a similar code in hwpoison_inject function to
> > check if the address is located in SGX Memory. The error will then be
> > handled by the arch_memory_failure function in the SGX driver.
>
> Looks good to me.
>
> [I wish that Linux hadn't called this "hwpoison_inject()" because there's nothing
> hardware related about this injection. But you are just an innocent consumer of
> that poor naming choice]
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
Thanks, Tony, for your review.
Cheers,
Thomas
>
> -Tony
next prev parent reply other threads:[~2022-09-27 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 18:34 [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory Thomas Tai
2022-09-27 20:34 ` Luck, Tony
2022-09-27 21:41 ` Thomas Tai [this message]
2022-09-28 7:59 ` Miaohe Lin
2022-09-28 12:23 ` Thomas Tai
2022-09-30 21:44 ` Jarkko Sakkinen
2022-10-02 14:56 ` Thomas Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB46238985ADC07034B781A338FD559@SJ0PR10MB4623.namprd10.prod.outlook.com \
--to=thomas.tai@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=reinette.chatre@intel.co \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).