From: Shai Malin <smalin@marvell.com>
To: Adrian Bunk <bunk@kernel.org>, Ariel Elior <aelior@marvell.com>,
Sudarsana Reddy Kalluru <skalluru@marvell.com>,
GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] bnx2x: Fix enabling network interfaces without VFs
Date: Mon, 13 Sep 2021 08:14:33 +0000 [thread overview]
Message-ID: <SJ0PR18MB38825BC9620238DE3327C64FCCD99@SJ0PR18MB3882.namprd18.prod.outlook.com> (raw)
On 9/12/2021 at 10:08PM, Adrian Bunk Wrote:
> This function is called to enable SR-IOV when available,
> not enabling interfaces without VFs was a regression.
>
> Fixes: 65161c35554f ("bnx2x: Fix missing error code in bnx2x_iov_init_one()")
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Reported-by: YunQiang Su <wzssyqa@gmail.com>
> Tested-by: YunQiang Su <wzssyqa@gmail.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index f255fd0b16db..6fbf735fca31 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -1224,7 +1224,7 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int
> int_mode_param,
>
> /* SR-IOV capability was enabled but there are no VFs*/
> if (iov->total == 0) {
> - err = -EINVAL;
> + err = 0;
> goto failed;
> }
Thanks for reporting this issue!
But the complete fix should also not use "goto failed".
Instead, please create a new "goto skip_vfs" so it will skip
the log of "Failed err=".
>
> --
> 2.20.1
next reply other threads:[~2021-09-13 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 8:14 Shai Malin [this message]
2021-09-13 10:41 ` [PATCH] bnx2x: Fix enabling network interfaces without VFs Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2021-09-13 11:18 Shai Malin
2021-09-15 2:28 ` Jakub Kicinski
2021-09-12 19:05 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR18MB38825BC9620238DE3327C64FCCD99@SJ0PR18MB3882.namprd18.prod.outlook.com \
--to=smalin@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).