From: "Yuan, Perry" <Perry.Yuan@dell.com>
To: "Limonciello, Mario" <Mario.Limonciello@dell.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"oder_chiou@realtek.com" <oder_chiou@realtek.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: RE: [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control support
Date: Wed, 13 Jan 2021 01:44:48 +0000 [thread overview]
Message-ID: <SJ0PR19MB4528FA846E29C0BB197725CA84A90@SJ0PR19MB4528.namprd19.prod.outlook.com> (raw)
In-Reply-To: <BY3PR19MB49130372226D65A235757BA1FAAA0@BY3PR19MB4913.namprd19.prod.outlook.com>
> -----Original Message-----
> From: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Sent: 2021年1月12日 22:48
> To: Yuan, Perry; Pierre-Louis Bossart; oder_chiou@realtek.com;
> perex@perex.cz; tiwai@suse.com
> Cc: alsa-devel@alsa-project.org; lgirdwood@gmail.com; linux-
> kernel@vger.kernel.org; broonie@kernel.org
> Subject: RE: [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control support
>
> > > -----Original Message-----
> > > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > > Sent: 2021年1月12日 2:07
> > > To: Yuan, Perry; oder_chiou@realtek.com; perex@perex.cz;
> > > tiwai@suse.com
> > > Cc: alsa-devel@alsa-project.org; Limonciello, Mario;
> > > lgirdwood@gmail.com; linux-kernel@vger.kernel.org;
> > > broonie@kernel.org
> > > Subject: Re: [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control
> > > support
> > >
> > >
> > > [EXTERNAL EMAIL]
> > >
> > >
> > >
> > >
> > > > @@ -268,6 +269,7 @@ static int rt715_sdca_put_volsw(struct
> > > > snd_kcontrol
> > > *kcontrol,
> > > > unsigned int reg2 = mc->rreg;
> > > > unsigned int reg = mc->reg;
> > > > unsigned int max = mc->max;
> > > > + unsigned int val0, val1;
> > > > int err;
> > > >
> > > > val = ucontrol->value.integer.value[0]; @@ -286,7 +288,22 @@
> > > > static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol,
> > > > if (err < 0)
> > > > return err;
> > > > }
> > > > -
> > > > +#if IS_ENABLED(CONFIG_DELL_PRIVACY)
> > > > + /* Privacy LED Trigger State Changed by muted/unmute switch */
> > > > + if (mc->invert) {
> > > > + val0 = ucontrol->value.integer.value[0];
> > > > + val1 = ucontrol->value.integer.value[1];
> > > > + if (val0 == 1 && val1 == 1) {
> > > > + rt715->micmute_led = LED_OFF;
> > > > + ledtrig_audio_set(LED_AUDIO_MICMUTE,
> > > > + rt715->micmute_led ? LED_ON :
> > > LED_OFF);
> > > > + } else if (val0 == 0 && val1 == 0) {
> > > > + rt715->micmute_led = LED_ON;
> > > > + ledtrig_audio_set(LED_AUDIO_MICMUTE,
> > > > + rt715->micmute_led ? LED_ON :
> > > LED_OFF);
> > > > + }
> > > > + }
> > > > +#endif
> > >
> > > Should this be activated for specific DMI quirks? This driver is
> > > used in
> > non-Dell
> > > platforms (I am thinking of Intel RVPs or Realtek daughterboards), I
> > > am not sure if a build-time behavior change makes sense.
> > >
> > > Or conversely could we just set the LEDs unconditionally if doing so
> > > is harmless?
> >
> > The current mic mute led setting path is not common used for other
> > vendors, just Dell platform support this mic mute led set operation.
> >
> > Do you think that I need to add one DMI quirk in the next version ?
> > If so, I can add that.
> >
> >
>
>
> In the HDA audio case this is modeled off of, the code runs whether or not a
> vendor has support for a mic mute LED. The calls to ledtrig_audio_set should
> be a no-op. I agree with @Pierre-Louis Bossart in this case, we should just be
> running it whether or not dell-privacy is compiled in. If another vendor
> chooses to add LED support they'll just need to set up their ledtrig supported
> backend and not change codec code.
Hi @Pierre-Louis Bossart
Seems like that we have two way to go.
* DMI quirks,seems like that it needs to maintain the quirk list when vendors have new system to support.
* We just set the mic mute led state unconditionally .
Which way would you prefer for next patch review?
next prev parent reply other threads:[~2021-01-13 1:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 13:38 [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control support Perry Yuan
2020-12-29 12:40 ` Mark Brown
2021-01-04 9:10 ` Yuan, Perry
2021-01-04 19:31 ` Limonciello, Mario
2021-01-11 18:07 ` Pierre-Louis Bossart
2021-01-12 5:27 ` Yuan, Perry
2021-01-12 14:47 ` Limonciello, Mario
2021-01-13 1:44 ` Yuan, Perry [this message]
2021-01-13 2:41 ` Pierre-Louis Bossart
2021-01-13 6:28 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR19MB4528FA846E29C0BB197725CA84A90@SJ0PR19MB4528.namprd19.prod.outlook.com \
--to=perry.yuan@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).