From: "Luck, Tony" <tony.luck@intel.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>,
Borislav Petkov <bp@alien8.de>,
Elliott Mitchell <ehem+xen@m5p.com>
Cc: "smita.koralahallichannabasappa@amd.com"
<smita.koralahallichannabasappa@amd.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"rric@kernel.org" <rric@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>
Subject: RE: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests"
Date: Wed, 13 Sep 2023 15:50:12 +0000 [thread overview]
Message-ID: <SJ1PR11MB6083BDC4D10D139EF28E0058FCF0A@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <40d3399a-b260-4ffa-a503-40c61468a189@amd.com>
> Also, please note that the EDAC modules don't handle MCE events
> directly. They act on information passed from the MCE subsystem.
>
> Furthermore, there are other EDAC modules that have the same !hypervisor
> check, so why change only this one?
The older Intel EDAC drivers translated system physical addresses to DIMM
addresses by digging around in the CONFIG and MMIO space of the memory
controller devices. It would seem unwise for a VMM to give access to those
addresses to a guest (in general ... perhaps OK for a Xen style "DOM0" guest that is
handling many tasks for the VMM?).
What system resources do AMD EDAC drivers need access to? Could they
work inside a guest?
-Tony
next prev parent reply other threads:[~2023-09-13 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 17:27 [PATCH] EDAC/mce_amd: Do not load edac_mce_amd module on guests Smita Koralahalli
2021-07-08 20:41 ` Yazen Ghannam
2021-07-23 18:18 ` Kim Phillips
2021-08-09 10:44 ` Borislav Petkov
2023-09-08 3:08 ` [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests" Elliott Mitchell
2023-09-08 3:59 ` Borislav Petkov
2023-09-13 14:36 ` Yazen Ghannam
2023-09-13 15:50 ` Luck, Tony [this message]
2023-09-13 16:21 ` Yazen Ghannam
2023-09-14 17:02 ` Elliott Mitchell
2023-09-15 11:56 ` Borislav Petkov
2023-09-21 21:18 ` Elliott Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB6083BDC4D10D139EF28E0058FCF0A@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=ehem+xen@m5p.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rric@kernel.org \
--cc=smita.koralahallichannabasappa@amd.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).