From: "Luck, Tony" <tony.luck@intel.com>
To: "Torvalds, Linus" <torvalds@linux-foundation.org>,
Jakub Jelinek <jakub@redhat.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Peter Zijlstra <peterz@infradead.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Eranian, Stephane" <eranian@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
"peternewman@google.com" <peternewman@google.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"babu.moger@amd.com" <babu.moger@amd.com>,
"ananth.narayan@amd.com" <ananth.narayan@amd.com>,
"vschneid@redhat.com" <vschneid@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
"linux-toolchains@vger.kernel.org"
<linux-toolchains@vger.kernel.org>
Subject: RE: [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in
Date: Tue, 7 Mar 2023 21:11:04 +0000 [thread overview]
Message-ID: <SJ1PR11MB6083CADB2B6E859915D456F7FCB79@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAHk-=whOLcy=oz=gHyoSSEnqc3M-APKFKTtTvA_3wYYPV8L+oA@mail.gmail.com>
> (a) it shouldn't define and declare a static function in a header file
>
> (b) the resctrl_sched_in() inline function is midesigned to begin with
Fixing "b" would seem to be to just pass "next_p" to the function to
use instead of "current".
Can you expand about part "a" ... Linux has zillions of static inline functions
in header files to handle CONFIG options. One version is the real McCoy
while the other is just a stub for the CONFIG=n case.
What's different about this one?
-Tony
next prev parent reply other threads:[~2023-03-07 21:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 23:11 [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in Stephane Eranian
2023-03-03 23:17 ` Luck, Tony
2023-03-06 12:01 ` Peter Zijlstra
2023-03-07 0:16 ` Nick Desaulniers
2023-03-07 11:35 ` Peter Zijlstra
2023-03-07 17:48 ` Linus Torvalds
2023-03-07 18:43 ` Segher Boessenkool
2023-03-07 20:43 ` Jakub Jelinek
2023-03-07 20:54 ` Linus Torvalds
2023-03-07 21:06 ` Linus Torvalds
2023-03-07 21:35 ` Luck, Tony
2023-03-07 21:58 ` Nick Desaulniers
2023-03-08 6:13 ` Stephane Eranian
2023-03-08 23:25 ` Linus Torvalds
2023-03-08 16:02 ` Moger, Babu
2023-03-07 21:11 ` Luck, Tony [this message]
2023-03-07 21:14 ` Linus Torvalds
2023-03-07 21:23 ` Luck, Tony
2023-03-08 0:36 ` Luck, Tony
2023-03-07 21:16 ` Nick Desaulniers
2023-03-07 21:19 ` Linus Torvalds
2023-03-07 21:22 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB6083CADB2B6E859915D456F7FCB79@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=ananth.narayan@amd.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jakub@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=segher@kernel.crashing.org \
--cc=torvalds@linux-foundation.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).