From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"irqbalance@lists.infradead.org" <irqbalance@lists.infradead.org>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>,
Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
Chaitra Basappa <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Subject: Re: Observing Softlockup's while running heavy IOs
Date: Thu, 18 Aug 2016 14:59:59 +0000 [thread overview]
Message-ID: <SN1PR0201MB1870C7DFF1595905BDAE985F81150@SN1PR0201MB1870.namprd02.prod.outlook.com> (raw)
In-Reply-To: CAK=zhgqkByFSYRYcY75+55kP0ysHbgpk1L9=qxAfLdoFfsa6sQ@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On 08/17/16 22:55, Sreekanth Reddy wrote:
> Observing softlockups while running heavy IOs on 8 SSD drives
> connected behind our LSI SAS 3004 HBA.
Hello Sreekanth,
This means that more than 23s was spent before the scheduler was
invoked, probably due to a loop. Can you give the attached (untested)
patch a try to see whether it is the loop in __blk_mq_run_hw_queue()?
Thanks,
Bart.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-block-Measure-__blk_mq_run_hw_queue-execution-time.patch --]
[-- Type: text/x-patch; name="0001-block-Measure-__blk_mq_run_hw_queue-execution-time.patch", Size: 1132 bytes --]
From 4da94f2ec37ee5d1b4a5f1ce2886bdafd5cd394c Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bart.vanassche@sandisk.com>
Date: Thu, 18 Aug 2016 07:51:49 -0700
Subject: [PATCH] block: Measure __blk_mq_run_hw_queue() execution time
Note: the "max_elapsed" variable can be modified by multiple threads
concurrently.
---
block/blk-mq.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index e931a0e..6d0961c 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -792,6 +792,9 @@ static void __blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx)
LIST_HEAD(driver_list);
struct list_head *dptr;
int queued;
+ static long max_elapsed = -1;
+ unsigned long start = jiffies;
+ long elapsed;
WARN_ON(!cpumask_test_cpu(raw_smp_processor_id(), hctx->cpumask));
@@ -889,6 +892,13 @@ static void __blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx)
**/
blk_mq_run_hw_queue(hctx, true);
}
+
+ elapsed = jiffies - start;
+ if (elapsed > max_elapsed) {
+ max_elapsed = elapsed;
+ pr_info("%s() finished after %d ms\n", __func__,
+ jiffies_to_msecs(elapsed));
+ }
}
/*
--
2.9.2
next prev parent reply other threads:[~2016-08-19 3:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 5:55 Observing Softlockup's while running heavy IOs Sreekanth Reddy
2016-08-18 14:59 ` Bart Van Assche [this message]
2016-08-18 21:08 ` Elliott, Robert (Persistent Memory)
2016-08-19 11:44 ` Sreekanth Reddy
2016-08-19 15:56 ` Bart Van Assche
2016-09-01 10:31 ` Sreekanth Reddy
2016-09-01 23:04 ` Bart Van Assche
[not found] ` <CAK=zhgrLL22stCfwKdpJkN=PkxPVxL=K9RgpP1USEbg_xx5TEg@mail.gmail.com>
2016-09-06 15:06 ` Neil Horman
2016-09-07 6:00 ` Sreekanth Reddy
2016-09-07 13:24 ` Neil Horman
2016-09-08 5:42 ` Sreekanth Reddy
2016-09-08 13:39 ` Neil Horman
2016-09-12 8:18 ` Sreekanth Reddy
2016-09-12 12:03 ` Neil Horman
2016-08-19 21:27 ` Elliott, Robert (Persistent Memory)
2016-08-23 9:52 ` Kashyap Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN1PR0201MB1870C7DFF1595905BDAE985F81150@SN1PR0201MB1870.namprd02.prod.outlook.com \
--to=bart.vanassche@sandisk.com \
--cc=chaitra.basappa@broadcom.com \
--cc=irqbalance@lists.infradead.org \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).