From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752509AbbKWMMe (ORCPT ); Mon, 23 Nov 2015 07:12:34 -0500 Received: from mail-bn1on0067.outbound.protection.outlook.com ([157.56.110.67]:42592 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751485AbbKWMMc convert rfc822-to-8bit (ORCPT ); Mon, 23 Nov 2015 07:12:32 -0500 X-Greylist: delayed 1091 seconds by postgrey-1.27 at vger.kernel.org; Mon, 23 Nov 2015 07:12:32 EST From: Avi Shchislowski To: Holger Schurig , Ulf Hansson , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alex Lemberg Subject: RE: [RFC 0/6] mmc: Field Firmware Update Thread-Topic: [RFC 0/6] mmc: Field Firmware Update Thread-Index: AQHRHiN2H0ds2I2Q6EmigJ/sKaaOwZ6piITw Date: Mon, 23 Nov 2015 11:40:04 +0000 Message-ID: References: <1447426572-11756-1-git-send-email-holgerschurig@gmail.com> In-Reply-To: <1447426572-11756-1-git-send-email-holgerschurig@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Avi.Shchislowski@sandisk.com; x-originating-ip: [63.163.107.100] x-microsoft-exchange-diagnostics: 1;DM2PR02MB286;5:7s9ofQKmKolfsPqEozi5Yo+oepytmcv7olrjUcGTwP/BIe4BtIfB8meG7VZLgIYPo75yXneN3jC0ryV8oITonTkGJ1crHWG1FS/xSztvx7TPL5npEXYuzPR+wqdHC71PzAUTKjIpsu7uKuLgOUyorA==;24:R08P3xchzldZVWzlyDf1QU3jduquHJntdGI2Er7XHBFcnm5KrcYehmNLcbGrrdNj+4RMhyN6L1I22lwUYUgzAG67pC9YsvP5G1220LzZuwM=;20:si+EALjzFVNsFXv+KtqG1dnJpPgart4sWopR2/poK30ucbjH+d+gaTZKuGflT+Syy/4VskGki/L5hnY9Vgrs2Pc0kmqae+vmsi5fA7sSGSN+H9qIcn2OpZ847Oa1IvOXkG0K4wTqkX9COstF3OsYr4U1bd6sXlh8LcYP3YrGCmNNN4R6waiBAPyaenQxI8tzehtRCVWsFgEgqcSYAwWilGpI5t3VT009KW/8X/fIxRzoHEWKPQnN+ri8k+HO27IX x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB286; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42932892334569); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(10201501046)(3002001);SRVR:DM2PR02MB286;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB286; x-forefront-prvs: 07697999E6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(164054003)(13464003)(377454003)(189002)(199003)(66066001)(5002640100001)(76576001)(106356001)(5003600100002)(74316001)(99286002)(106116001)(5007970100001)(10400500002)(19580395003)(1691005)(2201001)(19580405001)(5008740100001)(5001920100001)(5001960100002)(107886002)(97736004)(101416001)(86362001)(3846002)(76176999)(102836003)(5001770100001)(33656002)(50986999)(40100003)(122556002)(5004730100002)(2501003)(81156007)(6116002)(54356999)(10710500006)(2900100001)(189998001)(4001450100002)(11100500001)(2420400006)(87936001)(92566002)(2950100001)(7110500001)(105586002)(15975445007)(586003)(77096005);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR02MB286;H:SN1PR02MB1389.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2015 11:40:04.8272 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB286 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Holger, Thank you for resubmitting the FFU patches again. We did couple of fixes since our last submission (in [RFC 6/6]), so we will post them soon. Also, we would like to leave the original "signed-off-by" names in your FFU patch commits. Could you please add the original: Signed-off-by: Avi Shchislowski Signed-off-by: Alex Lemberg Thanks, Avi & Alex > -----Original Message----- > From: Holger Schurig [mailto:holgerschurig@gmail.com] > Sent: Friday, November 13, 2015 4:56 PM > To: Ulf Hansson; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; Avi > Shchislowski; Alex Lemberg > Cc: Holger Schurig > Subject: [RFC 0/6] mmc: Field Firmware Update > > There have been some attempts to add FFU (field firmware update). The last > AFAIK in Nov 2014, http://www.spinics.net/lists/linux-mmc/msg29324.html > > But it seems that the committers weren't persistent enought. > > I took the liberty to take Avi's patch and make it hopefully maintainer-review > friendly. > > The first 5 patches just move functions out of mmc_test.c into core.c. Those > functions will later be used by both mmc_test.c and mmc_ffu.c. Contrary to > Avi's patch I didn't add static helper functions to mmc_test.c, e.g. > there's no mmc_test_prepare_mrq() that calls mmc_prepare_mrq(). It's > simpler to call mmc_prepare_mrq() directly. It's just one more dereference > from *mmc_card to *mmc_test_card anyway. > > The patch [6/6] is http://www.spinics.net/lists/linux-mmc/msg29326.html, but > with less checkpatch warnings. And it doesn't use mmc_send_ext_csd() > anymore, which has been deleted since November. > > I'm sending this patch as RFC now. It compiles (for me). But I get the firmware > update file from Kingston only next Tuesday. That means that so far I haven't > been testing it. It won't do anything without the proper user-space command in > mmc-utils anyway :-) > > Comments welcome (I intent to get this patch into the kernel) > > The patch is against Linux GIT (v4.3-11748-g46d862b). > > Holger > > drivers/mmc/card/Kconfig | 11 + > drivers/mmc/card/Makefile | 1 + > drivers/mmc/card/block.c | 5 + > drivers/mmc/card/mmc_ffu.c | 489 > ++++++++++++++++++++++++++++++++++++++++++++ > drivers/mmc/card/mmc_test.c | 235 +++++---------------- > drivers/mmc/core/core.c | 134 ++++++++++++ > drivers/mmc/core/mmc_ops.c | 4 +- > include/linux/mmc/card.h | 1 + > include/linux/mmc/core.h | 41 ++++ > include/linux/mmc/mmc.h | 6 + > 10 files changed, 739 insertions(+), 188 deletions(-) create mode 100644 > drivers/mmc/card/mmc_ffu.c > > -- > 2.1.4