From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032AbbJ0GZF (ORCPT ); Tue, 27 Oct 2015 02:25:05 -0400 Received: from mail-by2on0104.outbound.protection.outlook.com ([207.46.100.104]:54169 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753493AbbJ0GY7 (ORCPT ); Tue, 27 Oct 2015 02:24:59 -0400 From: Zhao Qiang To: Scott Wood CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xiaobo Xie , "benh@kernel.crashing.org" , Li Leo , "paulus@samba.org" Subject: RE: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common Thread-Topic: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common Thread-Index: AQHRBlElIY3cieyJU0OjKYHBttck5p54c/eAgABKHfCAAN/SAIADhAFwgAG20YCAABo+QA== Date: Tue, 27 Oct 2015 06:24:56 +0000 Message-ID: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-4-git-send-email-qiang.zhao@freescale.com> <1445569799.701.142.camel@freescale.com> <1445633780.701.228.camel@freescale.com> <1445921289.701.301.camel@freescale.com> In-Reply-To: <1445921289.701.301.camel@freescale.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiang.zhao@freescale.com; x-originating-ip: [199.59.226.141] x-microsoft-exchange-diagnostics: 1;BN3PR03MB1478;5:BLH/a6UTyz4M+i70xwNJbFPajGjbk4jrfTxw3PCHa9JO4YpM0OSE9+yLqEY1yLf+2ZwNOAZM/Tvayz0cU39MvPqZdMlWiwPnFSGTJCDYzIp3kxyZfFe/EAX5Z7rfMWmO8b5nynZtTQhC1qu9QHnGeg==;24:KnePi7A4PEZHWD0xHBW2WRVu2n5qs2KcCca34coGCCF3LAjRYduAaoAG4a9DEGCPfGjfSjtWa8Iyeaq4VEu7SxqRNKKf4o4VetZa+55LRrA=;20:COWEE40SM0mYF79s7JQD0M2/2N777kVT+J+2TPKU2HJrtki1vuNk6GuJFyluKdlqg3ktOCKSGDEaDQG8jQKvQg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1478; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(102215026);SRVR:BN3PR03MB1478;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1478; x-forefront-prvs: 0742443479 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(13464003)(377454003)(189002)(377424004)(24454002)(54534003)(199003)(66066001)(77096005)(33656002)(102836002)(92566002)(19580405001)(10400500002)(5004730100002)(97736004)(81156007)(19580395003)(4001150100001)(101416001)(5007970100001)(76576001)(93886004)(40100003)(76176999)(54356999)(106116001)(87936001)(5003600100002)(50986999)(122556002)(110136002)(189998001)(106356001)(2950100001)(86362001)(2900100001)(74316001)(105586002)(5001960100002)(4001450100002)(5002640100001)(99286002)(5008740100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1478;H:SN1PR0301MB1550.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2015 06:24:56.5322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1478 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t9R6S5Pm027833 On Tue, Oct 27, 2015 at 12:48 PM, Wood Scott-B07421 wrote: > -----Original Message----- > From: Wood Scott-B07421 > Sent: Tuesday, October 27, 2015 12:48 PM > To: Zhao Qiang-B45475 > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > paulus@samba.org > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to > qe_common > > On Sun, 2015-10-25 at 21:42 -0500, Zhao Qiang-B45475 wrote: > > On Sat, Oct 24, 2015 at 04:56 AM, Wood Scott-B07421 wrote: > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Saturday, October 24, 2015 4:56 AM > > > To: Zhao Qiang-B45475 > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > > paulus@samba.org > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > functions > > > to qe_common > > > > > > On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote: > > > > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421 > > > > > > > > wrote: > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Friday, October 23, 2015 11:10 AM > > > > > To: Zhao Qiang-B45475 > > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 > > > > > ; paulus@samba.org > > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > > functions > > > > > to qe_common > > > > > > > > > > On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote: > > > > > > QE and CPM have the same muram, they use the same management > > > > > > functions. Now QE support both ARM and PowerPC, it is > > > > > > necessary to move QE to "driver/soc", so move the muram > > > > > > management functions from cpm_common to qe_common for > > > > > > preparing to move QE code to > > > "driver/soc" > > > > > > > > > > > > Signed-off-by: Zhao Qiang > > > > > > --- > > > > > > Changes for v2: > > > > > > - no changes > > > > > > Changes for v3: > > > > > > - no changes > > > > > > Changes for v4: > > > > > > - no changes > > > > > > Changes for v5: > > > > > > - no changes > > > > > > Changes for v6: > > > > > > - using genalloc instead rheap to manage QE MURAM > > > > > > - remove qe_reset from platform file, using > > > > > > - subsys_initcall to call qe_init function. > > > > > > Changes for v7: > > > > > > - move this patch from 3/3 to 2/3 > > > > > > - convert cpm with genalloc > > > > > > - check for gen_pool allocation failure Changes for v8: > > > > > > - rebase > > > > > > - move BD_SC_* macro instead of copy Changes for v9: > > > > > > - doesn't modify CPM, add a new patch to modify. > > > > > > - rebase > > > > > > Changes for v10: > > > > > > - rebase > > > > > > Changes for v11: > > > > > > - remove renaming > > > > > > - delete removing qe_reset and delete adding qe_init. > > > > > > Changes for v12: > > > > > > - SPI_FSL_CPM depends on QE-MURAM, select QUICC_ENGINE for > it. > > > > > > > > > > Why is the SPI change part of this patch? Why is it even part > > > > > of this patchset, rather than an independent patch sent to the > > > > > SPI list and maintainer? If it's tied to other changes you're > > > > > making, explain that. As is, there is zero mention of the SPI > > > > > change in the part of the e-mail that will become the git changelog. > > > > > > > > > This SPI_FSL_CPM is cpm-spi, it is part of CPM. > > > > > > So then why are you selecting QUICC_ENGINE? And again, what does it > > > have to do with this patch? > > > > Cpm-spi is dependent on qe_muram, if not select it, Cpm-spi will > > failed to build. > > Why QUICC_ENGINE and not CPM? QE and CPM use the same muram, and it has been moved to qe_muram from cpm_muram. > > -Scott {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I