From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbbJZCdI (ORCPT ); Sun, 25 Oct 2015 22:33:08 -0400 Received: from mail-by2on0136.outbound.protection.outlook.com ([207.46.100.136]:9910 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752387AbbJZCdG (ORCPT ); Sun, 25 Oct 2015 22:33:06 -0400 From: Zhao Qiang To: Scott Wood CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xiaobo Xie , "benh@kernel.crashing.org" , Li Leo , "paulus@samba.org" Subject: RE: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc Thread-Topic: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc Thread-Index: AQHRBlEqbwh27h0U/UGccn1ELB8VNp54droAgABKhsCAANx1gIADgoVw Date: Mon, 26 Oct 2015 02:33:03 +0000 Message-ID: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-6-git-send-email-qiang.zhao@freescale.com> <20151023031952.GA31843@home.buserror.net> <1445633739.701.227.camel@freescale.com> In-Reply-To: <1445633739.701.227.camel@freescale.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiang.zhao@freescale.com; x-originating-ip: [192.158.241.86] x-microsoft-exchange-diagnostics: 1;BY1PR03MB1482;5:exdOALUQqK92TGh7Qc/ePEZNkqLT1dbU3BvOcjM8RWDWw7ZK1hzRCOvB4cC+j/qrej+GV8oEu6n8DOuv9octIdAfzN/3NNYy9izb61LF6iDzFA6vSn6kOv2aHhEge1btRQVZikuVG31Q3Ian+MRDSg==;24:Q4tJlBcQBXpVvUmRpckkRVJfABcCkUZ8ughd9Ywjkms1Mb1jYPPWWpJJTkznOKiV8GuYWuG7UKiwhu/Xr/TtCTs/V4OGlH8afbPrHLhmRc4=;20:HigkHSZQtAKTcMijYqvABrdhpIb3/sFh6APrq0aB3E70LDsZ7QUXiLLsKVNrRac30mTNW+qhNWZ8U0pi7TGXvg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(102215026);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; x-forefront-prvs: 0741C77572 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(13464003)(199003)(189002)(377424004)(105586002)(19580405001)(19580395003)(74316001)(93886004)(106116001)(33656002)(106356001)(76576001)(92566002)(11100500001)(66066001)(99286002)(5004730100002)(97736004)(2900100001)(5001920100001)(2950100001)(5008740100001)(10400500002)(5002640100001)(4001150100001)(102836002)(77096005)(5007970100001)(81156007)(110136002)(5001960100002)(4001450100002)(87936001)(101416001)(50986999)(54356999)(86362001)(76176999)(122556002)(189998001)(5003600100002)(40100003)(575784001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:SN1PR0301MB1550.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2015 02:33:03.0515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t9Q2XEsj020111 On Sat, Oct 24, 2015 at 04:56 AM, Wood Scott-B07421 wrote: > -----Original Message----- > From: Wood Scott-B07421 > Sent: Saturday, October 24, 2015 4:56 AM > To: Zhao Qiang-B45475 > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > paulus@samba.org > Subject: Re: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc > > On Fri, 2015-10-23 at 02:49 -0500, Zhao Qiang-B45475 wrote: > > On Fri, Oct 23, 2015 at 11:20 AM, Wood Scott-B07421 > > > > wrote: > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Friday, October 23, 2015 11:20 AM > > > To: Zhao Qiang-B45475 > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > > paulus@samba.org > > > Subject: Re: [PATCH v12 6/6] QE: Move QE from arch/powerpc to > > > drivers/soc > > > > > > On Wed, Oct 14, 2015 at 03:16:08PM +0800, Zhao Qiang wrote: > > > > > > > > > > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig > > > > b/drivers/soc/fsl/qe/Kconfig similarity index 50% copy from > > > > arch/powerpc/sysdev/qe_lib/Kconfig > > > > copy to drivers/soc/fsl/qe/Kconfig index 3c25199..283fe0d 100644 > > > > --- a/arch/powerpc/sysdev/qe_lib/Kconfig > > > > +++ b/drivers/soc/fsl/qe/Kconfig > > > > @@ -2,6 +2,17 @@ > > > > # QE Communication options > > > > # > > > > > > > > +config QUICC_ENGINE > > > > + bool "Freescale QUICC Engine (QE) Support" > > > > + depends on FSL_SOC && PPC32 > > > > + select GENERIC_ALLOCATOR > > > > + select CRC32 > > > > + help > > > > + The QUICC Engine (QE) is a new generation of communications > > > > + coprocessors on Freescale embedded CPUs (akin to CPM in older > > > chips). > > > > + Selecting this option means that you wish to build a kernel > > > > + for a machine with a QE coprocessor. > > > > + > > > > config UCC_SLOW > > > > bool > > > > default y if SERIAL_QE > > > > @@ -19,9 +30,3 @@ config UCC_FAST > > > > config UCC > > > > bool > > > > default y if UCC_FAST || UCC_SLOW > > > > - > > > > -config QE_USB > > > > - bool > > > > - default y if USB_FSL_QE > > > > - help > > > > - QE USB Controller support > > > > > > Why did some config symbols get moved and others not? > > > > Because QE_USB should be putted under drivers/usb, It is independent > > of this patchset. > > If it's independent of this patchset then don't put it in this patchset. > Move all the QE stuff to drivers/soc and then later if something belongs > somewhere else, have a separate patch move it there. Ok -Zhao {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I