From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752244AbbJ0Hez (ORCPT ); Tue, 27 Oct 2015 03:34:55 -0400 Received: from mail-bn1on0130.outbound.protection.outlook.com ([157.56.110.130]:57376 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750701AbbJ0Hex (ORCPT ); Tue, 27 Oct 2015 03:34:53 -0400 X-Greylist: delayed 101950 seconds by postgrey-1.27 at vger.kernel.org; Tue, 27 Oct 2015 03:34:53 EDT From: Zhao Qiang To: Scott Wood CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xiaobo Xie , "benh@kernel.crashing.org" , Li Leo , "paulus@samba.org" Subject: RE: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common Thread-Topic: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common Thread-Index: AQHRBlElIY3cieyJU0OjKYHBttck5p54c/eAgABKHfCAAN/SAIADhAFwgAG20YCAABo+QIAAB/CAgAAL3lA= Date: Tue, 27 Oct 2015 07:34:49 +0000 Message-ID: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-4-git-send-email-qiang.zhao@freescale.com> <1445569799.701.142.camel@freescale.com> <1445633780.701.228.camel@freescale.com> <1445921289.701.301.camel@freescale.com> <1445928629.701.323.camel@freescale.com> In-Reply-To: <1445928629.701.323.camel@freescale.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiang.zhao@freescale.com; x-originating-ip: [199.59.226.141] x-microsoft-exchange-diagnostics: 1;BY2PR0301MB0726;5:eYFB8l/qE9vgD11IhIRx2d64sxBLsUwDHlLoatFK6BgjXwBINN9Y8vTjHJnAeQ1mD5bnv2zXMGbTOtRqi9RUNUHAJmHR51s8uqh2hHOlurLLfCpFDH5oYr28+dXoXhK4XHvXU6TLGJOzQy2WWoxxWA==;24:dYTDqBowoxupM2e07uiOmkZ7cDlIeeuxuE87Dq9kSz7af+Tu/zH1cZX+ffHePMs+omXJOYNVDPI/G4xGPgaBMpxOqJuYkgHpJEq37wSXttA=;20:w9fn8K1niK3X6p2hWQr28127ZJpkeoYqTPEvLWRT5XXnjzbvtRybClTLAGSwYsq8BmIPqngWWtBgBwhfTjQ5jw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0726; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(102215026);SRVR:BY2PR0301MB0726;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0726; x-forefront-prvs: 0742443479 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(24454002)(13464003)(189002)(377424004)(199003)(2950100001)(50986999)(2900100001)(76176999)(106356001)(101416001)(99286002)(54356999)(5001960100002)(5002640100001)(4001150100001)(105586002)(5001920100001)(97736004)(189998001)(5003600100002)(106116001)(76576001)(4001450100002)(81156007)(110136002)(86362001)(87936001)(33656002)(66066001)(74316001)(5004730100002)(19580395003)(122556002)(19580405001)(5007970100001)(102836002)(10400500002)(93886004)(92566002)(40100003)(5008740100001)(77096005);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB0726;H:SN1PR0301MB1550.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2015 07:34:49.5176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0726 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t9R7Z0eI028084 On Tue, Oct 27, 2015 at 2:50 PM, Wood Scott-B07421 wrote: > -----Original Message----- > From: Wood Scott-B07421 > Sent: Tuesday, October 27, 2015 2:50 PM > To: Zhao Qiang-B45475 > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > paulus@samba.org > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to > qe_common > > On Tue, 2015-10-27 at 01:24 -0500, Zhao Qiang-B45475 wrote: > > On Tue, Oct 27, 2015 at 12:48 PM, Wood Scott-B07421 wrote: > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Tuesday, October 27, 2015 12:48 PM > > > To: Zhao Qiang-B45475 > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > > paulus@samba.org > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > functions > > > to qe_common > > > > > > On Sun, 2015-10-25 at 21:42 -0500, Zhao Qiang-B45475 wrote: > > > > On Sat, Oct 24, 2015 at 04:56 AM, Wood Scott-B07421 wrote: > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Saturday, October 24, 2015 4:56 AM > > > > > To: Zhao Qiang-B45475 > > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 > > > > > ; paulus@samba.org > > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > > functions > > > > > to qe_common > > > > > > > > > > On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote: > > > > > > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421 > > > > > > > > > > > > wrote: > > > > > > > -----Original Message----- > > > > > > > From: Wood Scott-B07421 > > > > > > > Sent: Friday, October 23, 2015 11:10 AM > > > > > > > To: Zhao Qiang-B45475 > > > > > > > Cc: linux-kernel@vger.kernel.org; > > > > > > > linuxppc-dev@lists.ozlabs.org; lauraa@codeaurora.org; Xie > > > > > > > Xiaobo-R63061 ; > > > > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 > > > > > > > ; paulus@samba.org > > > > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > > > > functions > > > > > > > to qe_common > > > > > > > > > > > > So then why are you selecting QUICC_ENGINE? And again, what > > > > > does it have to do with this patch? > > > > > > > > Cpm-spi is dependent on qe_muram, if not select it, Cpm-spi will > > > > failed to build. > > > > > > Why QUICC_ENGINE and not CPM? > > > > QE and CPM use the same muram, and it has been moved to qe_muram > from > > cpm_muram. > > Fix the makefiles so that the muram code continues to be built for both > QUICC_ENGINE and CPM. It's not acceptable to have to bring in the entire QE > code just for the muram. > How about to define and CONFIG_QE_MURAM in Kconfig for muram? -Zhao {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I