From: Nava kishore Manne <navam@xilinx.com>
To: Xu Yilun <yilun.xu@intel.com>
Cc: "mdf@kernel.org" <mdf@kernel.org>,
"hao.wu@intel.com" <hao.wu@intel.com>,
"trix@redhat.com" <trix@redhat.com>,
Michal Simek <michals@xilinx.com>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, git <git@xilinx.com>
Subject: RE: [PATCH v3 5/5] fpga: fpga-region: Add missing kernel-doc description
Date: Thu, 7 Apr 2022 05:31:39 +0000 [thread overview]
Message-ID: <SN6PR02MB45766BEFCA6532873271099FC2E69@SN6PR02MB4576.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20220405053547.GA249845@yilunxu-OptiPlex-7050>
Hi Yilun,
Thanks for providing the review comments.
Please find my response inline.
> -----Original Message-----
> From: Xu Yilun <yilun.xu@intel.com>
> Sent: Tuesday, April 5, 2022 11:06 AM
> To: Nava kishore Manne <navam@xilinx.com>
> Cc: mdf@kernel.org; hao.wu@intel.com; trix@redhat.com; Michal Simek
> <michals@xilinx.com>; linux-fpga@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git
> <git@xilinx.com>
> Subject: Re: [PATCH v3 5/5] fpga: fpga-region: Add missing kernel-doc
> description
>
> On Sun, Apr 03, 2022 at 10:46:41AM +0530, Nava kishore Manne wrote:
> > Fixed the warnings: No description found for return value of 'xxx'
>
> The commit message is not clear. There are descriptions for some functions,
> but not in right format.
>
I agree for some functions has description but not in the right format.
The "Description Not exits" and "Description not in the right format" in both cases the tool will report the same warning ie; " warnings: No description found for return value of 'xxx'"
This patch address the above warning. So to make it relevant I have added the same in the commit msg.
Regards,
Navakishore.
next prev parent reply other threads:[~2022-04-07 5:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 5:16 [PATCH v3 0/5]fpga: fix for coding style and kernel-doc issues Nava kishore Manne
2022-04-03 5:16 ` [PATCH v3 1/5] fpga: zynq: Fix incorrect variable type Nava kishore Manne
2022-04-05 4:38 ` Xu Yilun
2022-04-05 16:00 ` Russ Weight
2022-04-03 5:16 ` [PATCH v3 2/5] fpga: fix for coding style issues Nava kishore Manne
2022-04-03 5:16 ` [PATCH v3 3/5] fpga: fpga-mgr: Add missing kernel-doc description Nava kishore Manne
2022-04-03 5:16 ` [PATCH v3 4/5] fpga: Use tab instead of space indentation Nava kishore Manne
2022-04-03 5:16 ` [PATCH v3 5/5] fpga: fpga-region: Add missing kernel-doc description Nava kishore Manne
2022-04-05 5:35 ` Xu Yilun
2022-04-07 5:31 ` Nava kishore Manne [this message]
2022-04-07 6:48 ` Xu Yilun
2022-04-16 13:18 ` Nava kishore Manne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR02MB45766BEFCA6532873271099FC2E69@SN6PR02MB4576.namprd02.prod.outlook.com \
--to=navam@xilinx.com \
--cc=git@xilinx.com \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michals@xilinx.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).