From: Avri Altman <Avri.Altman@wdc.com>
To: Rob Clark <robdclark@gmail.com>, Asutosh Das <asutoshd@codeaurora.org>
Cc: "cang@codeaurora.org" <cang@codeaurora.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Subhash Jadavani <subhashj@codeaurora.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Colin Ian King <colin.king@canonical.com>,
Bart Van Assche <bvanassche@acm.org>,
open list <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: RE: [PATCH v1 1/3] scsi: ufs: add write booster feature support
Date: Sun, 21 Jun 2020 07:40:27 +0000 [thread overview]
Message-ID: <SN6PR04MB46402FD7981F9FCA2111AB37FC960@SN6PR04MB4640.namprd04.prod.outlook.com> (raw)
In-Reply-To: <CAF6AEGvgmfYoybv4XMVVH85fGMr-eDfpzxdzkFWCx-2N5PEw2w@mail.gmail.com>
>
> On Wed, Apr 8, 2020 at 3:00 PM Asutosh Das <asutoshd@codeaurora.org>
> wrote:
> >
> > The write performance of TLC NAND is considerably
> > lower than SLC NAND. Using SLC NAND as a WriteBooster
> > Buffer enables the write request to be processed with
> > lower latency and improves the overall write performance.
> >
> > Adds support for shared-buffer mode WriteBooster.
> >
> > WriteBooster enable: SW enables it when clocks are
> > scaled up, thus it's enabled only in high load conditions.
> >
> > WriteBooster disable: SW will disable the feature,
> > when clocks are scaled down. Thus writes would go as normal
> > writes.
>
> btw, in v5.8-rc1 (plus handful of remaining patches for lenovo c630
> laptop (sdm850)), I'm seeing a lot of:
>
> ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for
> idn 14 failed, err = 253
> ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for
> idn 14 failed, err = 253
> ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag_retry: query attribute,
> opcode 6, idn 14, failed with error 253 after 3 retires
> ufshcd-qcom 1d84000.ufshc: ufshcd_wb_ctrl write booster enable failed 253
>
> and at least subjectively, compiling mesa seems slower, which seems
> like it might be related?
This looks like a device issue to be taken with the flash vendor:
The device reports that it supports wd, but returns inalid idn for flag 0xe...
Thanks,
Avri
next prev parent reply other threads:[~2020-06-21 7:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1586374414.git.asutoshd@codeaurora.org>
2020-04-08 21:48 ` [PATCH v1 1/3] scsi: ufs: add write booster feature support Asutosh Das
2020-04-08 21:48 ` [PATCH v1 2/3] ufs-qcom: scsi: configure write booster type Asutosh Das
2020-04-08 21:48 ` [PATCH v1 3/3] ufs: sysfs: add sysfs entries for write booster Asutosh Das
2020-04-12 12:43 ` [PATCH v1 1/3] scsi: ufs: add write booster feature support Avri Altman
2020-04-21 20:01 ` Asutosh Das (asd)
2020-06-20 21:13 ` Rob Clark
2020-06-21 7:40 ` Avri Altman [this message]
2020-06-21 7:55 ` Bjorn Andersson
2020-06-21 16:50 ` Rob Clark
2020-06-21 17:50 ` Steev Klimaszewski
2020-06-23 4:34 ` Kyuho Choi
2020-06-23 6:09 ` Avri Altman
2020-06-23 6:51 ` Kyuho Choi
2020-06-24 1:10 ` Steev Klimaszewski
2020-06-24 1:53 ` Stanley Chu
2020-06-24 2:06 ` Kyuho Choi
2020-06-24 2:49 ` Stanley Chu
2020-06-24 16:15 ` Steev Klimaszewski
2020-06-25 3:29 ` Stanley Chu
2020-06-24 1:54 ` Kyuho Choi
2020-04-21 22:54 ` [PATCH v2 " Asutosh Das
2020-04-21 22:54 ` [PATCH v2 2/3] ufs: sysfs: add sysfs entries for write booster Asutosh Das
2020-04-22 8:49 ` Avri Altman
2020-04-21 22:54 ` [PATCH v2 3/3] ufs-qcom: scsi: configure write booster type Asutosh Das
2020-04-22 8:51 ` Avri Altman
2020-04-22 10:28 ` [PATCH v2 1/3] scsi: ufs: add write booster feature support Avri Altman
2020-04-22 10:35 ` Avri Altman
2020-04-22 21:41 ` [PATCH v3 " Asutosh Das
2020-04-22 21:41 ` [PATCH v3 2/3] ufs: sysfs: add sysfs entries for write booster Asutosh Das
2020-04-22 21:41 ` [PATCH v3 3/3] ufs-qcom: scsi: configure write booster type Asutosh Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR04MB46402FD7981F9FCA2111AB37FC960@SN6PR04MB4640.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robdclark@gmail.com \
--cc=stanley.chu@mediatek.com \
--cc=subhashj@codeaurora.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).