linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
	MSM <linux-arm-msm@vger.kernel.org>,
	SCSI <linux-scsi@vger.kernel.org>
Cc: Jeffrey Hugo <jhugo@codeaurora.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Evan Green <evgreen@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Pedro Sousa <pedrom.sousa@synopsys.com>,
	Rob Herring <robh+dt@kernel.org>,
	Kishon Vijay Abraham <kishon@ti.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Martin Petersen <martin.petersen@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 6/7] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"
Date: Sat, 9 Feb 2019 09:07:41 +0000	[thread overview]
Message-ID: <SN6PR04MB49252A044910AC48672F1043FC6A0@SN6PR04MB4925.namprd04.prod.outlook.com> (raw)
In-Reply-To: <817ff724-2a30-99fb-8a92-c77797651bde@free.fr>

Hi,
> 
> This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490.
> 
> Calling ufshcd_set_vccq_rail_unused() breaks UFS init on two boards.
> I would say that vccq is *not* not needed.
> 
> Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Those  tags got switched off.

I still think that If you are reverting the quirk implementation,
you should remove the quirk listing as well.

Also, as the v3 discussion held on several threads,
and new people might be joining in, 
maybe you could reply to this patch with a couple of sentences summing-up
the various theories that this bring-up raised.

Thanks,
Avri 

  reply	other threads:[~2019-02-09  9:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 22:09 [PATCH v4 0/7] UFS on APQ8098/MSM8998 Marc Gonzalez
2019-02-08 22:11 ` [PATCH v4 1/7] dt-bindings: ufs: Fix the compatible string definition Marc Gonzalez
2019-02-08 22:11 ` [PATCH v4 2/7] dt-bindings: ufs: Add msm8998 compatible string Marc Gonzalez
2019-02-08 22:13 ` [PATCH v4 3/7] dt-bindings: phy-qcom-qmp: Add qcom,msm8998-qmp-ufs-phy Marc Gonzalez
2019-02-08 22:14 ` [PATCH v4 4/7] phy: qcom-qmp: Add QMP UFS PHY support for msm8998 Marc Gonzalez
2019-02-08 22:15 ` [PATCH v4 5/7] arm64: dts: qcom: msm8998: Allow drivers to set-load Marc Gonzalez
2019-02-08 22:20 ` [PATCH v4 6/7] Revert "scsi: ufs: disable vccq if it's not needed by UFS device" Marc Gonzalez
2019-02-09  9:07   ` Avri Altman [this message]
2019-02-09  9:54     ` Marc Gonzalez
2019-02-08 22:22 ` [PATCH v4 7/7] arm64: dts: qcom: msm8998: Add UFS nodes Marc Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR04MB49252A044910AC48672F1043FC6A0@SN6PR04MB4925.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=david.brown@linaro.org \
    --cc=dianders@chromium.org \
    --cc=evgreen@chromium.org \
    --cc=jhugo@codeaurora.org \
    --cc=kishon@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=martin.petersen@oracle.com \
    --cc=pedrom.sousa@synopsys.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).