From: Avri Altman <Avri.Altman@wdc.com>
To: Sayali Lokhande <sayalil@codeaurora.org>,
"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"vivek.gautam@codeaurora.org" <vivek.gautam@codeaurora.org>,
"rnayak@codeaurora.org" <rnayak@codeaurora.org>,
"vinholikatti@gmail.com" <vinholikatti@gmail.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"evgreen@chromium.org" <evgreen@chromium.org>,
"riteshh@codeaurora.org" <riteshh@codeaurora.org>
Cc: "stummala@codeaurora.org" <stummala@codeaurora.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"jlbec@evilplan.org" <jlbec@evilplan.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V15 2/2] scsi: ufs: Add configfs support for UFS provisioning
Date: Tue, 16 Oct 2018 09:43:22 +0000 [thread overview]
Message-ID: <SN6PR04MB4925BBEF6D9360B64DCF7F88FCFE0@SN6PR04MB4925.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1539680382-31136-3-git-send-email-sayalil@codeaurora.org>
Hi,
> +++ b/drivers/scsi/ufs/Makefile
> @@ -4,6 +4,8 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PCI) += tc-dwc-g210-
> pci.o ufshcd-dwc.o tc-dwc-g210.
> obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-dwc-g210-pltfrm.o
> ufshcd-dwc.o tc-dwc-g210.o
> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
> -ufshcd-core-objs := ufshcd.o ufs-sysfs.o
> +ufshcd-core-objs-y := ufshcd.o ufs-sysfs.o
> +ufshcd-core-objs-$(CONFIG_SCSI_UFS_PROVISION) += ufs-configfs.o
> +ufshcd-core-objs := $(ufshcd-core-objs-y)
This will work, but I think it should be:
ufshcd-core-y += ufshcd.o ufs-sysfs.o
ufshcd-core-$( CONFIG_SCSI_UFS_PROVISION) += ufs-configfs.o
Also, you may want to rebase your patches with Martin's 4.20/scsi-queue
Thanks,
Avri
next prev parent reply other threads:[~2018-10-16 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1539680382-31136-1-git-send-email-sayalil@codeaurora.org>
2018-10-16 8:59 ` [PATCH V15 1/2] scsi: ufs: set the device reference clock setting Sayali Lokhande
2018-10-18 14:30 ` Rob Herring
2018-10-16 8:59 ` [PATCH V15 2/2] scsi: ufs: Add configfs support for UFS provisioning Sayali Lokhande
2018-10-16 9:43 ` Avri Altman [this message]
2018-10-17 7:56 Bean Huo (beanhuo)
2018-10-17 8:33 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR04MB4925BBEF6D9360B64DCF7F88FCFE0@SN6PR04MB4925.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=evgreen@chromium.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=riteshh@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).