From: <Don.Brace@microchip.com>
To: <pmenzel@molgen.mpg.de>, <Mike.McGowen@microchip.com>
Cc: <Kevin.Barnett@microchip.com>, <Scott.Teel@microchip.com>,
<Justin.Lindley@microchip.com>, <Scott.Benesh@microchip.com>,
<Gerry.Morong@microchip.com>, <Mahesh.Rajashekhara@microchip.com>,
<Murthy.Bhat@microchip.com>, <Balsundar.P@microchip.com>,
<joseph.szczypek@hpe.com>, <jeff@canonical.com>,
<POSWALD@suse.com>, <john.p.donnelly@oracle.com>,
<mwilck@suse.com>, <linux-kernel@vger.kernel.org>,
<hch@infradead.org>, <martin.peterson@oracle.com>,
<jejb@linux.vnet.ibm.com>, <linux-scsi@vger.kernel.org>
Subject: RE: [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member
Date: Thu, 8 Jul 2021 21:17:53 +0000 [thread overview]
Message-ID: <SN6PR11MB284815D78832CA5B5E4EA701E1199@SN6PR11MB2848.namprd11.prod.outlook.com> (raw)
In-Reply-To: <fa3b5d5a-fdd3-48c7-b8d5-1a732b09bf68@molgen.mpg.de>
From: Paul Menzel [mailto:pmenzel@molgen.mpg.de]
Subject: Re: [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member
Dear Don, dear Mike,
Am 06.07.21 um 20:16 schrieb Don Brace:
> From: Mike McGowen <mike.mcgowen@microchip.com>
>
> Correct driver's ISR accessing a data structure member that has not
> been fully initialized during driver init.
Does that crash the Linux kernel?
Don:
No. I updated the title and description to reflect this. It resulted in some brief access to uninitialized members.
This was found during some internal testing, no bugs were ever filed for this change.
Thanks for your review.
> - The pqi queue groups can be null when an interrupt fires.
If it fixes a crash(?), please add a Fixes: tag so it can be backported to the stable series.
Kind regards,
Paul
next prev parent reply other threads:[~2021-07-08 21:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 18:16 [smartpqi updates PATCH 0/9] smartpqi updates Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 1/9] smartpqi: add pci id for H3C controller Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 2/9] smartpqi: rm unsupported controller features msgs Don Brace
2021-07-07 7:28 ` Paul Menzel
2021-07-08 19:04 ` Don.Brace
2021-07-09 7:24 ` Paul Menzel
2021-07-09 15:06 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 3/9] smartpqi: update copyright notices Don Brace
2021-07-07 7:35 ` Paul Menzel
2021-07-08 19:10 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 4/9] smartpqi: add SCSI cmd info for resets Don Brace
2021-07-07 7:37 ` Paul Menzel
2021-07-08 20:20 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 5/9] smartpqi: add PCI id for H3C P4408 controller Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 6/9] smartpqi: add PCI-ID for new Norsi controller Don Brace
2021-07-07 7:38 ` Paul Menzel
2021-07-08 21:35 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 7/9] smartpqi: add PCI IDs for new ZTE controllers Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member Don Brace
2021-07-07 7:48 ` Paul Menzel
2021-07-08 21:17 ` Don.Brace [this message]
2021-07-06 18:16 ` [smartpqi updates PATCH 9/9] smartpqi: update version to 2.1.10-020 Don Brace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB284815D78832CA5B5E4EA701E1199@SN6PR11MB2848.namprd11.prod.outlook.com \
--to=don.brace@microchip.com \
--cc=Balsundar.P@microchip.com \
--cc=Gerry.Morong@microchip.com \
--cc=Justin.Lindley@microchip.com \
--cc=Kevin.Barnett@microchip.com \
--cc=Mahesh.Rajashekhara@microchip.com \
--cc=Mike.McGowen@microchip.com \
--cc=Murthy.Bhat@microchip.com \
--cc=POSWALD@suse.com \
--cc=Scott.Benesh@microchip.com \
--cc=Scott.Teel@microchip.com \
--cc=hch@infradead.org \
--cc=jeff@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.p.donnelly@oracle.com \
--cc=joseph.szczypek@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.peterson@oracle.com \
--cc=mwilck@suse.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).