From: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ashok Raj <ashok.raj@intel.com>
Subject: RE: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
Date: Mon, 11 Mar 2019 22:10:29 +0000 [thread overview]
Message-ID: <SN6PR12MB2639C9CC6B5BA0A1F1FE771DF8480@SN6PR12MB2639.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190311204217.GA1810@agluck-desk>
> -----Original Message-----
> From: Luck, Tony <tony.luck@intel.com>
> Sent: Monday, March 11, 2019 3:42 PM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: Borislav Petkov <bp@alien8.de>; x86@kernel.org; linux-kernel@vger.kernel.org; Ashok Raj <ashok.raj@intel.com>
> Subject: Re: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
>
> On Mon, Mar 11, 2019 at 08:25:53PM +0000, Ghannam, Yazen wrote:
> > > + if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
> > > + goto log_it;
> > > +
> >
> > Can you please include a vendor check with this? MCi_STATUS[56] is
> > not defined the same way on AMD systems.
>
> Original code also looked at MCi_STATUS[56] without a vendor
> check:
>
> > > - (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))
>
> Was this OK because you don't set mca_cfg.ser?
>
> If so, my new code will also skip out before getting to this test. But
> should probably have a better comment. Something like:
>
>
> /*
> * Newer Intel systems that support software error
> * recovery need to make some extra checks. Other
> * CPUs should skip over uncorrected errors, but log
> * everything else
> */
> if (!mca_cfg.ser) {
> if (m.status & MCI_STATUS_UC)
> continue;
> goto log_it;
> }
>
Yes, you're right. Thanks for pointing that out.
-Yazen
next prev parent reply other threads:[~2019-03-11 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 18:51 [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log Tony Luck
2019-03-11 20:25 ` Ghannam, Yazen
2019-03-11 20:42 ` Luck, Tony
2019-03-11 22:10 ` Ghannam, Yazen [this message]
2019-03-12 17:09 ` [PATCH v2] x86, mce: Fix machine_check_poll() tests for which errors Luck, Tony
2019-03-27 9:58 ` [tip:ras/core] x86/mce: Fix machine_check_poll() tests for error types tip-bot for Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR12MB2639C9CC6B5BA0A1F1FE771DF8480@SN6PR12MB2639.namprd12.prod.outlook.com \
--to=yazen.ghannam@amd.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).