linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bharat Bhushan <bbhushan2@marvell.com>
To: Dongsheng Yang <dongsheng.yang@easystack.cn>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
	Dongsheng Yang <dongsheng.yang.linux@gmail.com>
Subject: RE: [EXTERNAL] [PATCH 7/7] cbd: add related sysfs files in transport register
Date: Thu, 25 Apr 2024 05:24:46 +0000	[thread overview]
Message-ID: <SN7PR18MB5314D1E502937E34BC5AC823E3172@SN7PR18MB5314.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240422071606.52637-8-dongsheng.yang@easystack.cn>



> -----Original Message-----
> From: Dongsheng Yang <dongsheng.yang@easystack.cn>
> Sent: Monday, April 22, 2024 12:46 PM
> To: dan.j.williams@intel.com; axboe@kernel.dk
> Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> cxl@vger.kernel.org; Dongsheng Yang <dongsheng.yang.linux@gmail.com>
> Subject: [EXTERNAL] [PATCH 7/7] cbd: add related sysfs files in transport
> register
> 
> Prioritize security for external emails: Confirm sender and content safety
> before clicking links or opening attachments
> 
> ----------------------------------------------------------------------
> From: Dongsheng Yang <dongsheng.yang.linux@gmail.com>
> 
> When a transport is registered, a corresponding file is created for each
> area within the transport in the sysfs, including "cbd_hosts",
> "cbd_backends", "cbd_blkdevs", and "cbd_channels".
> 
> Through these sysfs files, we can examine the information of each entity
> and thereby understand the relationships between them. This allows us to
> further understand the current operational status of the transport.
> 
> For example, by examining "cbd_hosts", we can find all the hosts
> currently using the transport. We can also determine which host each
> backend is running on by looking at the "host_id" in "cbd_backends".
> Similarly, by examining "cbd_blkdevs", we can determine which host each
> blkdev is running on, and through the "mapped_id", we can know the name
> of the cbd device to which the blkdev is mapped. Additionally, by
> looking at "cbd_channels", we can determine which blkdev and backend are
> connected through each channel by examining the "blkdev_id" and
> "backend_id".
> 
> Signed-off-by: Dongsheng Yang <dongsheng.yang.linux@gmail.com>
> ---
>  drivers/block/cbd/cbd_transport.c | 101
> +++++++++++++++++++++++++++++-
>  1 file changed, 100 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/block/cbd/cbd_transport.c
> b/drivers/block/cbd/cbd_transport.c
> index 75b9d34218fc..0e917d72b209 100644
> --- a/drivers/block/cbd/cbd_transport.c
> +++ b/drivers/block/cbd/cbd_transport.c
> @@ -1,8 +1,91 @@
>  #include <linux/pfn_t.h>
> -
>  #include "cbd_internal.h"
> 
>  #define CBDT_OBJ(OBJ, OBJ_SIZE)
> 		\
> +extern struct device_type cbd_##OBJ##_type;
> 	\
> +extern struct device_type cbd_##OBJ##s_type;
> 	\
> +
> 	\
> +static int cbd_##OBJ##s_init(struct cbd_transport *cbdt)
> 	\
> +{
> 	\
> +	struct cbd_##OBJ##s_device *devs;
> 	\
> +	struct cbd_##OBJ##_device *cbd_dev;
> 	\
> +	struct device *dev;
> 	\
> +	int i;
> 	\
> +	int ret;								\
> +
> 	\
> +	u32 memsize = struct_size(devs, OBJ##_devs,
> 	\
> +			cbdt->transport_info->OBJ##_num);
> 	\
> +	devs = kzalloc(memsize, GFP_KERNEL);
> 	\
> +	if (!devs) {
> 	\
> +	    return -ENOMEM;
> 	\
> +	}

Do not need "{ } " here 

> 	\
> +
> 	\
> +	dev = &devs->OBJ##s_dev;
> 	\
> +	device_initialize(dev);
> 	\
> +	device_set_pm_not_required(dev);
> 	\
> +	dev_set_name(dev, "cbd_" #OBJ "s");
> 	\
> +	dev->parent = &cbdt->device;
> 	\
> +	dev->type = &cbd_##OBJ##s_type;
> 		\
> +	ret = device_add(dev);
> 	\
> +	if (ret) {								\
> +		goto devs_free;
> 	\
> +	}

Do not need "{ } " here

Thanks
-Bharat

> 	\
> +
> 	\
> +	for (i = 0; i < cbdt->transport_info->OBJ##_num; i++) {
> 	\
> +		cbd_dev = &devs->OBJ##_devs[i];
> 		\
> +		dev = &cbd_dev->dev;
> 	\
> +
> 	\
> +		cbd_dev->cbdt = cbdt;
> 	\
> +		cbd_dev->OBJ##_info = cbdt_get_##OBJ##_info(cbdt, i);
> 		\
> +		device_initialize(dev);
> 	\
> +		device_set_pm_not_required(dev);
> 	\
> +		dev_set_name(dev, #OBJ "%u", i);
> 	\
> +		dev->parent = &devs->OBJ##s_dev;
> 	\
> +		dev->type = &cbd_##OBJ##_type;
> 		\
> +
> 	\
> +		ret = device_add(dev);
> 	\
> +		if (ret) {							\
> +			i--;
> 	\
> +			goto del_device;
> 	\
> +		}
> 	\
> +	}
> 	\
> +	cbdt->cbd_##OBJ##s_dev = devs;
> 		\
> +
> 	\
> +    	return 0;
> 	\
> +del_device:
> 	\
> +	for (; i >= 0; i--) {
> 	\
> +		cbd_dev = &devs->OBJ##_devs[i];
> 		\
> +		dev = &cbd_dev->dev;
> 	\
> +		device_del(dev);
> 	\
> +	}
> 	\
> +devs_free:
> 	\
> +	kfree(devs);
> 	\
> +	return ret;
> 	\
> +}
> 	\
> +
> 	\
> +static void cbd_##OBJ##s_exit(struct cbd_transport *cbdt)
> 	\
> +{
> 	\
> +	struct cbd_##OBJ##s_device *devs = cbdt->cbd_##OBJ##s_dev;
> 	\
> +	struct device *dev;
> 	\
> +	int i;
> 	\
> +
> 	\
> +	if (!devs)
> 	\
> +		return;
> 	\
> +
> 	\
> +	for (i = 0; i < cbdt->transport_info->OBJ##_num; i++) {
> 	\
> +		struct cbd_##OBJ##_device *cbd_dev = &devs-
> >OBJ##_devs[i];	\
> +		dev = &cbd_dev->dev;
> 	\
> +
> 	\
> +		device_del(dev);
> 	\
> +	}
> 	\
> +
> 	\
> +	device_del(&devs->OBJ##s_dev);
> 		\
> +
> 	\
> +	kfree(devs);
> 	\
> +	cbdt->cbd_##OBJ##s_dev = NULL;
> 		\
> +
> 	\
> +	return;
> 	\
> +}
> 	\
> 
> 	\
>  static inline struct cbd_##OBJ##_info
> 	\
>  *__get_##OBJ##_info(struct cbd_transport *cbdt, u32 id)
> 		\
> @@ -588,6 +671,11 @@ int cbdt_unregister(u32 tid)
>  	}
>  	mutex_unlock(&cbdt->lock);
> 
> +	cbd_blkdevs_exit(cbdt);
> +	cbd_channels_exit(cbdt);
> +	cbd_backends_exit(cbdt);
> +	cbd_hosts_exit(cbdt);
> +
>  	cbd_host_unregister(cbdt);
>  	device_unregister(&cbdt->device);
>  	cbdt_dax_release(cbdt);
> @@ -647,9 +735,20 @@ int cbdt_register(struct cbdt_register_options
> *opts)
>  		goto dev_unregister;
>  	}
> 
> +	if (cbd_hosts_init(cbdt) || cbd_backends_init(cbdt) ||
> +	    cbd_channels_init(cbdt) || cbd_blkdevs_init(cbdt)) {
> +		ret = -ENOMEM;
> +		goto devs_exit;
> +	}
> +
>  	return 0;
> 
>  devs_exit:
> +	cbd_blkdevs_exit(cbdt);
> +	cbd_channels_exit(cbdt);
> +	cbd_backends_exit(cbdt);
> +	cbd_hosts_exit(cbdt);
> +
>  	cbd_host_unregister(cbdt);
>  dev_unregister:
>  	device_unregister(&cbdt->device);
> --
> 2.34.1
> 


  reply	other threads:[~2024-04-25  5:24 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22  7:15 [PATCH RFC 0/7] block: Introduce CBD (CXL Block Device) Dongsheng Yang
2024-04-22  7:16 ` [PATCH 1/7] block: Init for CBD(CXL " Dongsheng Yang
2024-04-22 18:39   ` Randy Dunlap
2024-04-22 22:41     ` Dongsheng Yang
2024-04-24  3:58   ` Chaitanya Kulkarni
2024-04-24  8:36     ` Dongsheng Yang
2024-04-22  7:16 ` [PATCH 2/7] cbd: introduce cbd_transport Dongsheng Yang
2024-04-24  4:08   ` Chaitanya Kulkarni
2024-04-24  8:43     ` Dongsheng Yang
2024-04-22  7:16 ` [PATCH 3/7] cbd: introduce cbd_channel Dongsheng Yang
2024-04-22  7:16 ` [PATCH 4/7] cbd: introduce cbd_host Dongsheng Yang
2024-04-25  5:51   ` [EXTERNAL] " Bharat Bhushan
2024-04-22  7:16 ` [PATCH 5/7] cbd: introuce cbd_backend Dongsheng Yang
2024-04-24  5:03   ` Chaitanya Kulkarni
2024-04-24  8:36     ` Dongsheng Yang
2024-04-25  5:46   ` [EXTERNAL] " Bharat Bhushan
2024-04-22  7:16 ` [PATCH 7/7] cbd: add related sysfs files in transport register Dongsheng Yang
2024-04-25  5:24   ` Bharat Bhushan [this message]
2024-04-22 22:42 ` [PATCH 6/7] cbd: introduce cbd_blkdev Dongsheng Yang
2024-04-23  7:27   ` Dongsheng Yang
2024-04-24  4:29 ` [PATCH RFC 0/7] block: Introduce CBD (CXL Block Device) Dan Williams
2024-04-24  6:33   ` Dongsheng Yang
2024-04-24 15:14     ` Gregory Price
2024-04-26  1:25       ` Dongsheng Yang
2024-04-26 13:48         ` Gregory Price
2024-04-26 14:53           ` Dongsheng Yang
2024-04-26 16:14             ` Gregory Price
2024-04-28  5:47               ` Dongsheng Yang
2024-04-28 16:44                 ` Gregory Price
2024-04-28 16:55                 ` John Groves
2024-05-03  9:52                   ` Jonathan Cameron
2024-05-08 11:39                     ` Dongsheng Yang
2024-05-08 12:11                       ` Jonathan Cameron
2024-05-08 13:03                         ` Dongsheng Yang
2024-05-08 15:44                           ` Jonathan Cameron
2024-05-09 11:24                             ` Dongsheng Yang
2024-05-09 12:21                               ` Jonathan Cameron
2024-05-09 13:03                                 ` Dongsheng Yang
2024-05-21 18:41                                   ` Dan Williams
2024-05-22  6:17                                     ` Dongsheng Yang
2024-05-29 15:25                                       ` Gregory Price
2024-05-30  6:59                                         ` Dongsheng Yang
2024-05-30 13:38                                           ` Jonathan Cameron
2024-06-01  3:22                                             ` Dan Williams
2024-06-03 12:48                                               ` Jonathan Cameron
2024-06-03 17:28                                                 ` James Morse
2024-06-04 14:26                                                   ` Jonathan Cameron
2024-05-31 14:23                                           ` Gregory Price
2024-06-03  1:33                                             ` Dongsheng Yang
2024-04-30  0:34                 ` Dan Williams
2024-04-24 18:08     ` Dan Williams
     [not found]       ` <539c1323-68f9-d753-a102-692b69049c20@easystack.cn>
2024-04-30  0:10         ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN7PR18MB5314D1E502937E34BC5AC823E3172@SN7PR18MB5314.namprd18.prod.outlook.com \
    --to=bbhushan2@marvell.com \
    --cc=axboe@kernel.dk \
    --cc=dan.j.williams@intel.com \
    --cc=dongsheng.yang.linux@gmail.com \
    --cc=dongsheng.yang@easystack.cn \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).