* [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add
@ 2012-01-15 15:16 Jason Dravet
2012-01-15 15:30 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Jason Dravet @ 2012-01-15 15:16 UTC (permalink / raw)
To: linux-kernel
This patch makes it clear that the problem is in the BIOS of the computer and not the kernel. This patch applies to kernel 3.2.1.
Reported-by: Greg White <pcguy11@live.com>
Signed-off-by: Jason Dravet <dravet@hotmail.com>
Tested-by: Greg White <pcguy11@live.com>
--- dir.orig 2012-01-14 18:58:20.026745884 -0600
+++ dir.c 2012-01-14 19:52:33.011444581 -0600
@@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
(path == NULL) ? sd->s_name :
strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
sd->s_name));
+ WARN(1, KERN_WARNING
+ "Your BIOS is broken. Please contact your computer manufacturer.");
kfree(path);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add
2012-01-15 15:16 [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add Jason Dravet
@ 2012-01-15 15:30 ` Dave Jones
[not found] ` <SNT144-W477468478D64073A33B390DF830@phx.gbl>
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2012-01-15 15:30 UTC (permalink / raw)
To: Jason Dravet; +Cc: linux-kernel
On Sun, Jan 15, 2012 at 09:16:13AM -0600, Jason Dravet wrote:
>
> This patch makes it clear that the problem is in the BIOS of the computer and not the kernel. This patch applies to kernel 3.2.1.
>
> Reported-by: Greg White <pcguy11@live.com>
> Signed-off-by: Jason Dravet <dravet@hotmail.com>
> Tested-by: Greg White <pcguy11@live.com>
>
> --- dir.orig 2012-01-14 18:58:20.026745884 -0600
> +++ dir.c 2012-01-14 19:52:33.011444581 -0600
> @@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
> (path == NULL) ? sd->s_name :
> strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
> sd->s_name));
> + WARN(1, KERN_WARNING
> + "Your BIOS is broken. Please contact your computer manufacturer.");
> kfree(path);
> }
That certainly isn't always the case. Incorrectly written drivers
have also taken this codepath before now.
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add
[not found] ` <SNT144-W477468478D64073A33B390DF830@phx.gbl>
@ 2012-01-16 21:28 ` Jason Dravet
0 siblings, 0 replies; 3+ messages in thread
From: Jason Dravet @ 2012-01-16 21:28 UTC (permalink / raw)
Cc: linux-kernel
> > This patch makes it clear that the problem is in the BIOS of
the computer and not the kernel. This patch applies to kernel 3.2.1.
> >
> > --- dir.orig 2012-01-14 18:58:20.026745884 -0600
> > +++ dir.c 2012-01-14 19:52:33.011444581 -0600
> > @@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
> > (path == NULL) ? sd->s_name :
> > strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
> > sd->s_name));
> > + WARN(1, KERN_WARNING
> > + "Your BIOS is broken. Please contact your computer manufacturer.");
> > kfree(path);
> > }
>
> That certainly isn't always the case. Incorrectly written drivers
> have also taken this codepath before now.
>
> Dave
Then how do you tell when the problem is the BIOS or a driver?
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-16 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-15 15:16 [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add Jason Dravet
2012-01-15 15:30 ` Dave Jones
[not found] ` <SNT144-W477468478D64073A33B390DF830@phx.gbl>
2012-01-16 21:28 ` Jason Dravet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).