From: Luke Jones <luke@ljones.dev>
To: linux-kernel@vger.kernel.org
Cc: hdegoede@redhat.com, hadess@hadess.net,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 0/1] asus-wmi: add platform_profile support
Date: Sat, 14 Aug 2021 19:51:29 +1200 [thread overview]
Message-ID: <THKTXQ.ELSNF0TA7RAV1@ljones.dev> (raw)
In-Reply-To: <20210814043103.2535842-1-luke@ljones.dev>
On Sat, Aug 14 2021 at 16:31:02 +1200, Luke D. Jones <luke@ljones.dev>
wrote:
> Changelog:
> - V2
> + Correctly unregister from platform_profile if
> throttle_thermal_policy fails
> + Do platform_profile_notify() in both
> throttle_thermal_policy_store()
> and in throttle_thermal_policy_switch_next()
> + Remove unnecessary prep for possible fan-boost modes as this
> doesn't match expected platform_profile behaviour
> - V3
> + Add missing declaration for err in
> throttle_thermal_policy_switch_next
>
> Luke D. Jones (1):
> asus-wmi: Add support for platform_profile
>
> drivers/platform/x86/asus-wmi.c | 139
> +++++++++++++++++++++++++++++++-
> 1 file changed, 135 insertions(+), 4 deletions(-)
>
> --
> 2.31.1
Hi,
I teested the patch again and it appears that the
platform_profile_notify() in both throttle_thermal_policy_store() and
throttle_thermal_policy_switch_next() updates the
/sys/firmware/acpi/platform_profile sysfs path fine, but userspace
isn't updated?
The way I'm checking is:
1. echo 1 |sudo tee
/sys/devices/platform/asus-nb-wmi/throttle_thermal_policy
2. cat -p /sys/firmware/acpi/platform_profile
- performance (updated correctly by platform_profile_notify)
3. Check gnome-settings, not updated.
Doing `echo "performance" |sudo tee
/sys/firmware/acpi/platform_profile` updates both
throttle_thermal_policy and userspace as expected. I'm wondering if
I've missed something?
Cheers,
Luke.
next prev parent reply other threads:[~2021-08-14 7:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 4:31 [PATCH v3 0/1] asus-wmi: add platform_profile support Luke D. Jones
2021-08-14 4:31 ` [PATCH v3 1/1] asus-wmi: Add support for platform_profile Luke D. Jones
2021-08-14 9:40 ` Andy Shevchenko
2021-08-14 11:46 ` Luke Jones
2021-08-14 12:47 ` Luke Jones
2021-08-14 19:51 ` Andy Shevchenko
2021-08-15 13:45 ` Hans de Goede
2021-08-14 19:49 ` Andy Shevchenko
2021-08-14 7:51 ` Luke Jones [this message]
2021-08-15 13:48 ` [PATCH v3 0/1] asus-wmi: add platform_profile support Hans de Goede
2021-08-15 14:10 ` Bastien Nocera
2021-08-15 23:00 ` Luke Jones
2021-08-16 8:09 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=THKTXQ.ELSNF0TA7RAV1@ljones.dev \
--to=luke@ljones.dev \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).