linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Zhou Yanjie <zhouyanjie@wanyeetech.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
	hminas@synopsys.com, devicetree@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-kernel@vger.kernel.org, dongsheng.qiu@ingenic.com,
	aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
	sihui.liu@ingenic.com, jun.jiang@ingenic.com,
	sernia.zhou@foxmail.com
Subject: Re: [PATCH 1/2] dt-bindings: dwc2: Add bindings for new Ingenic SoCs.
Date: Sun, 25 Jul 2021 11:31:41 +0100	[thread overview]
Message-ID: <TKQSWQ.K11YHBO0B4FM2@crapouillou.net> (raw)
In-Reply-To: <ad64396d-d7ab-b8dd-4086-f565e91edb00@wanyeetech.com>

Hi Zhou,

Le sam., juil. 24 2021 at 20:52:30 +0800, Zhou Yanjie 
<zhouyanjie@wanyeetech.com> a écrit :
> Hi Paul,
> 
> On 2021/7/24 下午6:46, Paul Cercueil wrote:
>> Hi Zhou,
>> 
>> Le sam., juil. 24 2021 at 16:48:40 +0800, 周琰杰 (Zhou Yanjie) 
>> \x7f<zhouyanjie@wanyeetech.com> a écrit :
>>> Add the dwc2 bindings for the JZ4775 SoC, the JZ4780 SoC, the X1000 
>>> SoC,
>>> the X1600 SoC, the X1830 SoC, and the X2000 SoC from Ingenic.
>>> 
>>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>>> ---
>>>  Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>> 
>>> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml 
>>> \x7f\x7fb/Documentation/devicetree/bindings/usb/dwc2.yaml
>>> index 10c7d9b..e779d33 100644
>>> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
>>> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
>>> @@ -14,6 +14,12 @@ properties:
>>>      oneOf:
>>>        - const: brcm,bcm2835-usb
>>>        - const: hisilicon,hi6220-usb
>>> +      - const: ingenic,jz4775-otg
>>> +      - const: ingenic,jz4780-otg
>>> +      - const: ingenic,x1000-otg
>>> +      - const: ingenic,x1600-otg
>>> +      - const: ingenic,x1830-otg
>>> +      - const: ingenic,x2000-otg
>> 
>> I don't know if all these IPs are the exact same, but if they are, 
>> \x7fthey all should have "ingenic,jz4775-otg" as the fallback.
> 
> 
> I'm not too sure whether they are exactly the same, but comparing the 
> code in Ingenics SDK,
> 
> the code of the USB part of jz4775, jz4780, and x1000 are the same, 
> the code of the USB part
> 
> of x1600 and x1830 are the same, and the USB part code of X2000 are 
> different from all of them.

In doubt - it's better to keep separate compatible strings, so this is 
OK.

Cheers,
-Paul



  reply	other threads:[~2021-07-25 10:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24  8:48 [PATCH 0/2] Add OTG support for " 周琰杰 (Zhou Yanjie)
2021-07-24  8:48 ` [PATCH 1/2] dt-bindings: dwc2: Add bindings for new " 周琰杰 (Zhou Yanjie)
2021-07-24 10:46   ` Paul Cercueil
2021-07-24 12:52     ` Zhou Yanjie
2021-07-25 10:31       ` Paul Cercueil [this message]
2021-07-30  9:33         ` Zhou Yanjie
2021-07-29 21:38   ` Rob Herring
2021-07-24  8:48 ` [PATCH 2/2] USB: dwc2: Add OTG support for " 周琰杰 (Zhou Yanjie)
2021-07-24 10:49   ` Paul Cercueil
2021-07-24 13:05     ` Zhou Yanjie
2021-07-24 13:24       ` Felipe Balbi
2021-07-27 14:27   ` Greg KH
2021-07-30  9:34     ` Zhou Yanjie
2021-07-30  6:33   ` Minas Harutyunyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TKQSWQ.K11YHBO0B4FM2@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=aric.pzqi@ingenic.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dongsheng.qiu@ingenic.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hminas@synopsys.com \
    --cc=jun.jiang@ingenic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rick.tyliu@ingenic.com \
    --cc=robh+dt@kernel.org \
    --cc=sernia.zhou@foxmail.com \
    --cc=sihui.liu@ingenic.com \
    --cc=zhouyanjie@wanyeetech.com \
    --subject='Re: [PATCH 1/2] dt-bindings: dwc2: Add bindings for new Ingenic SoCs.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).