From: Chris Brandt <Chris.Brandt@renesas.com>
To: Jason Yan <yanaijie@huawei.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Nishka Dasgupta <nishkadg.linux@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH] pinctrl: rza1: remove unused 'rza1l_swio_pins'
Date: Fri, 17 Apr 2020 11:15:07 +0000 [thread overview]
Message-ID: <TY1PR01MB156234F694E0056AB7CD7FFC8AD90@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <76de8e85-d9a5-c58f-206e-15da59ee110e@huawei.com>
On Fri, Apr 17, 2020, Jason Yan wrote:
> >> static const struct rza1_bidir_entry rza1l_bidir_entries[RZA1_NPORTS]
> = {
> >> [1] = { ARRAY_SIZE(rza1l_bidir_pins_p1), rza1l_bidir_pins_p1 },
> >> [3] = { ARRAY_SIZE(rza1l_bidir_pins_p3), rza1l_bidir_pins_p3 },
> >
> > rza1l_swio_pins[] is unused because rza1l_swio_entries[] refers to the
> > wrong array. So I'd rather see a patch to fix that instead.
> >
>
> Thanks for the explanation, I will send a new one.
Looks like that one was my typo.
Thank you Geert for pointing that out!
Chris
prev parent reply other threads:[~2020-04-17 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:20 [PATCH] pinctrl: rza1: remove unused 'rza1l_swio_pins' Jason Yan
2020-04-17 9:31 ` Geert Uytterhoeven
2020-04-17 10:35 ` Jason Yan
2020-04-17 11:15 ` Chris Brandt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY1PR01MB156234F694E0056AB7CD7FFC8AD90@TY1PR01MB1562.jpnprd01.prod.outlook.com \
--to=chris.brandt@renesas.com \
--cc=geert@linux-m68k.org \
--cc=hulkci@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).