From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
USB list <linux-usb@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()
Date: Wed, 29 Nov 2017 08:21:22 +0000 [thread overview]
Message-ID: <TY1PR06MB0992899AE427576E3F83CF54D83B0@TY1PR06MB0992.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1711281004170.1467-100000@iolanthe.rowland.org>
Hi,
> From: Alan Stern, Sent: Wednesday, November 29, 2017 12:07 AM
>
> On Tue, 28 Nov 2017, Yoshihiro Shimoda wrote:
>
> > Hi Geert-san,
> >
> > > From: Geert Uytterhoeven, Sent: Tuesday, November 28, 2017 7:58 PM
> > >
> > > Hi Rafael, Shimoda-san,
> > >
> > > On Sun, Nov 12, 2017 at 1:27 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
<snip>
> > > JFTR, this triggered before during system resume on e.g. Salvator-XS with
> > > R-Car H3:
> > >
> > > ohci-platform ee080000.usb: runtime PM trying to suspend device
> > > but active child
> > > phy_rcar_gen3_usb2 ee080200.usb-phy: runtime PM trying to suspend
> > > device but active child
> > > ohci-platform ee0c0000.usb: runtime PM trying to suspend device
> > > but active child
> > > ohci-platform ee0a0000.usb: runtime PM trying to suspend device
> > > but active child
> > > phy_rcar_gen3_usb2 ee0c0200.usb-phy: runtime PM trying to suspend
> > > device but active child
> > > phy_rcar_gen3_usb2 ee0a0200.usb-phy: runtime PM trying to suspend
> > > device but active child
> > >
> > > so this was an existing issue with USB before.
> >
> > Thank you for the report!
> > I know that, but since this didn't cause any trouble until now,
> > I postponed to investigate the issue... But, I investigate it today.
> > I don't find the root cause yet. However, it seems related to usb host and/or usb core.
> > --> USB host related devices' child_count will be 1 in suspend timing.
> > --> I guess remote wakeup feature is enabled? But, I don't find the point yet.
> >
> > The renesas_usbhs also uses the phy_rcar_gen3_usb2 driver.
I'm so sorry, but this is mistake.
The renesas_usbhs doesn't use the phy_rcar_gen3_usb2 driver.
So,
> > --> If I only used the renesas_usbhs driver (in other words, I don't install
> > [eo]hci-{hcd,platform} drivers), the issue disappeared.
> > --> So, I think the phy_rcar_gen3_usb2 driver doesn't cause this issue.
> > (But, it is possible to be related though.)
They are also mistake.
> > I'll continue to investigate this issue tomorrow.
>
> Does the phy_rcar_gen3_usb2 driver use runtime PM?
Yes, the phy_rcar_gen3_usb2 uses runtime PM.
> It looks like the
> phy device somehow gets enabled for runtime PM when it shouldn't be.
I also think that now.
I don't find why for now, but the usage_count of a phy device was not 1 just before suspend.
(This "a phy device" means the child of ee0a0200.usb-phy device.)
> (And by the way, what device is the child of ee0a0200.usb-phy?)
It's a phy device:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?h=v4.15-rc1#n773
Best regards,
Yoshihiro Shimoda
> Alan Stern
next prev parent reply other threads:[~2017-11-29 8:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 0:27 [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status() Rafael J. Wysocki
2017-11-13 13:26 ` Ulf Hansson
2017-11-13 21:50 ` Rafael J. Wysocki
2017-11-13 21:58 ` Rafael J. Wysocki
2017-11-14 9:13 ` Ulf Hansson
2017-11-14 9:56 ` Ulf Hansson
2017-11-14 21:44 ` Rafael J. Wysocki
2017-11-15 7:22 ` Ulf Hansson
2017-11-16 9:22 ` Johan Hovold
2017-11-16 13:57 ` Rafael J. Wysocki
2017-11-28 10:58 ` Geert Uytterhoeven
2017-11-28 12:48 ` Yoshihiro Shimoda
2017-11-28 15:06 ` Alan Stern
2017-11-29 8:21 ` Yoshihiro Shimoda [this message]
2017-11-28 17:22 ` Ulf Hansson
2017-11-29 8:21 ` Yoshihiro Shimoda
2017-11-29 9:24 ` Ulf Hansson
2017-11-29 9:43 ` Geert Uytterhoeven
2017-11-29 9:59 ` Ulf Hansson
2017-11-29 14:09 ` Geert Uytterhoeven
2017-11-30 12:51 ` Yoshihiro Shimoda
2017-12-01 9:22 ` Ulf Hansson
2017-12-01 11:03 ` Yoshihiro Shimoda
2017-12-01 11:54 ` Yoshihiro Shimoda
2017-12-04 10:41 ` Ulf Hansson
2017-12-05 3:23 ` Yoshihiro Shimoda
2017-12-05 15:03 ` Alan Stern
2017-12-05 15:23 ` Rafael J. Wysocki
2017-12-05 15:48 ` Ulf Hansson
2017-11-28 14:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY1PR06MB0992899AE427576E3F83CF54D83B0@TY1PR06MB0992.apcprd06.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).