From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312AbdLALyq (ORCPT ); Fri, 1 Dec 2017 06:54:46 -0500 Received: from relmlor4.renesas.com ([210.160.252.174]:17447 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751989AbdLALyo (ORCPT ); Fri, 1 Dec 2017 06:54:44 -0500 X-IronPort-AV: E=Sophos;i="5.45,344,1508770800"; d="scan'208";a="263886605" From: Yoshihiro Shimoda To: Ulf Hansson CC: Geert Uytterhoeven , "Rafael J. Wysocki" , Linux PM , LKML , Greg Kroah-Hartman , Alan Stern , "USB list" , Linux-Renesas , Kishon Vijay Abraham I Subject: RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status() Thread-Topic: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status() Thread-Index: AQHTaDfS0q/eL1h6GUu734kOFriem6MpuB9wgABSgACAAPMO0IAAGbSAgAAFNYCAAARrAIABvQIAgAFdUQCAABPfAIAAFMJQ Date: Fri, 1 Dec 2017 11:54:39 +0000 Message-ID: References: <1713438.irjm9MTSvo@aspire.rjw.lan> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.139] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;TY1PR06MB0991;20:7CpYYlY73fp/PKd6Vc9KdY0S3w2NJDUJHe+gOinC12tdNqiPIJ34j3O6rHumCRK5tre4T1HhrXtUfgRIs3Lc5vY5JSmaPvqSvdCH8VeLLSZre/YRuYBpt4iPmeKIL0ajo2uXxUyfyWyqHYwSxumGkreRrcMulevhrGcg7m2RtSY= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 46a8da95-6977-4a13-f246-08d538b24d41 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286);SRVR:TY1PR06MB0991; x-ms-traffictypediagnostic: TY1PR06MB0991: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231022)(10201501046)(6055026)(6041248)(20161123558100)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:TY1PR06MB0991;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:TY1PR06MB0991; x-forefront-prvs: 05087F0C24 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(39860400002)(346002)(366004)(189002)(51444003)(199003)(106356001)(3280700002)(14454004)(99286004)(66066001)(105586002)(3660700001)(54356011)(54906003)(6506006)(77096006)(8936002)(7736002)(74316002)(76176011)(7696005)(2900100001)(305945005)(229853002)(7416002)(6436002)(86362001)(2940100002)(101416001)(6246003)(316002)(8676002)(55016002)(189998001)(81156014)(68736007)(53936002)(33656002)(81166006)(93886005)(25786009)(9686003)(6116002)(102836003)(3846002)(5660300001)(478600001)(2906002)(97736004)(4326008)(2950100002)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:TY1PR06MB0991;H:TY1PR06MB0992.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46a8da95-6977-4a13-f246-08d538b24d41 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2017 11:54:39.2107 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0991 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB1BspRK003060 Hi again, > From: Yoshihiro Shimoda, Sent: Friday, December 1, 2017 8:04 PM > > Hi, > > However, the following message still exists. > > Enabling runtime PM for inactive device (ee080000.usb) with active children > > So, I guess ohci-platform.c also has similar issue. > > JFYI, the ehci-platform.c doesn't have runtime PM handling. > So, I think that error message doesn't output from ehci devices. I have update. If I added to call pm_runtime_forbid() in ohci-platform.c like xhci-plat.c, the issue disappeared. I don't understand the pm_runtime_forbid() behavior yet, but is this acceptable? Best regards, Yoshihiro Shimoda > Best regards, > Yoshihiro Shimoda