linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Min Li <min.li.xe@renesas.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "richardcochran@gmail.com" <richardcochran@gmail.com>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net v5 3/3] ptp: clockmatrix: miscellaneous cosmetic change
Date: Fri, 13 May 2022 19:57:26 +0000	[thread overview]
Message-ID: <TYCPR01MB6608DC38FC74BB484E2B6079BACA9@TYCPR01MB6608.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20220512090300.162e5441@kernel.org>

> 
> First of all, I don't understand why you keep sending these patches for net.
> Please add more information about the changes to the commit messages.
> 
> For the formatting I was complaining about - you should fold updates to the
> code you're _already_modifying_ into the relevant patches.
> 
> You can clean up the rest of the code but definitely not in net. Code
> refactoring goes to net-next.
> 
> Perhaps a read of the netdev FAQ will elucidate what I'm on about:
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
> kernel.org%2Fdoc%2Fhtml%2Flatest%2Fprocess%2Fmaintainer-
> netdev.html&amp;data=05%7C01%7Cmin.li.xe%40renesas.com%7C3cbe9c7
> 3bb2e4e4765d608da3430e6c8%7C53d82571da1947e49cb4625a166a4a2
> a%7C0%7C0%7C637879681870307714%7CUnknown%7CTWFpbGZsb3d8ey
> JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7C3000%7C%7C%7C&amp;sdata=cYeTkW596blMW6amKHFPk7cgv9G%2B
> R7%2B0zZP72DJebDA%3D&amp;reserved=0

Hi Jakub

There are multiple places where "no empty line between call and error check" and "return directly"
like you pointed out before. Some are related to this change and some are not. Do you prefer to fix only
the related ones in this patch or do them all in another patch to net-next

Min

  reply	other threads:[~2022-05-13 19:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 14:25 [PATCH net v5 1/3] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support Min Li
2022-05-11 14:25 ` [PATCH net v5 2/3] ptp: ptp_clockmatrix: return -EBUSY if phase pull-in is in progress Min Li
2022-05-11 14:25 ` [PATCH net v5 3/3] ptp: clockmatrix: miscellaneous cosmetic change Min Li
2022-05-12  0:37   ` Jakub Kicinski
2022-05-12  3:12     ` Min Li
2022-05-12 16:03       ` Jakub Kicinski
2022-05-13 19:57         ` Min Li [this message]
2022-05-13 21:33           ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYCPR01MB6608DC38FC74BB484E2B6079BACA9@TYCPR01MB6608.jpnprd01.prod.outlook.com \
    --to=min.li.xe@renesas.com \
    --cc=kuba@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).