From: "TATSUKAWA KOSUKE(立川 江介)" <tatsu-ab1@nec.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] n_tty: wake up poll(POLLRDNORM) on receiving data
Date: Wed, 26 Jan 2022 23:34:39 +0000 [thread overview]
Message-ID: <TYCPR01MB81901234932D9FD1327DF093A5209@TYCPR01MB8190.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <YfFRVkmtSsXPanS5@kroah.com>
Hi, thank you for the reply.
> On Mon, Jan 24, 2022 at 08:17:22AM +0000, TATSUKAWA KOSUKE(立川 江介) wrote:
> > Event POLLRDNORM should be equivalent to POLLIN when used as event in
> > poll().
>
> Where is that documented?
It's in "man poll". Below is an excerpt from the man page.
POLLRDNORM
Equivalent to POLLIN.
I'll send a v2 patch in a separate message.
Many other calls to wake_up_interruptible_poll() in the kernel source
code already specify "POLLIN | POLLRDNORM", but there are places under
drivers/tty which only passes POLLIN (i.e. pty.c, tty_io.c,
tty_ldisc.c). I haven't yet made test programs to hit the other
locations and I wasn't sure if they should also be fixed just for
consistency.
Best regards.
> > However, in n_tty driver, POLLRDNORM does not return until
> > timeout even if there is terminal input, whereas POLLIN returns.
> >
> > The following test program works until kernel-3.17, but the test stops
> > in poll() after commit 57087d515441 ("tty: Fix spurious poll() wakeups").
> >
> > [Steps to run test program]
> > $ cc -o test-pollrdnorm test-pollrdnorm.c
> > $ ./test-pollrdnorm
> > foo <-- Type in something from the terminal followed by [RET].
> > The string should be echoed back.
> >
> > ------------------------< test-pollrdnorm.c >------------------------
> > #include <stdio.h>
> > #include <errno.h>
> > #include <poll.h>
> > #include <unistd.h>
> >
> > void main(void)
> > {
> > int n;
> > unsigned char buf[8];
> > struct pollfd fds[1] = {{ 0, POLLRDNORM, 0 }};
> >
> > n = poll(fds, 1, -1);
> > if (n < 0)
> > perror("poll");
> > n = read(0, buf, 8);
> > if (n < 0)
> > perror("read");
> > if (n > 0)
> > write(1, buf, n);
> > }
> > ------------------------------------------------------------------------
> >
> > The attached patch fixes this problem.
> >
> > Signed-off-by: Kosuke Tatsukawa <tatsu-ab1@nec.com>
> > Fixes: commit 57087d515441 ("tty: Fix spurious poll() wakeups")
>
> No need for "commit" here, please remove as the documentation asks you
> to.
>
> Can you resend this with this fixed up, and a pointer to where the
> documentation is for this functionality.
>
> thanks,
>
> greg k-h
---
Kosuke TATSUKAWA | 1st Platform Software Division
| NEC Solution Innovators
| tatsu-ab1@nec.com
prev parent reply other threads:[~2022-01-26 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 8:17 [PATCH] n_tty: wake up poll(POLLRDNORM) on receiving data TATSUKAWA KOSUKE(立川 江介)
2022-01-26 13:49 ` Greg Kroah-Hartman
2022-01-26 23:34 ` TATSUKAWA KOSUKE(立川 江介) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB81901234932D9FD1327DF093A5209@TYCPR01MB8190.jpnprd01.prod.outlook.com \
--to=tatsu-ab1@nec.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).