From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933221AbdKPH1P (ORCPT ); Thu, 16 Nov 2017 02:27:15 -0500 Received: from mail-os2jpn01on0075.outbound.protection.outlook.com ([104.47.92.75]:51456 "EHLO JPN01-OS2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932923AbdKPH1G (ORCPT ); Thu, 16 Nov 2017 02:27:06 -0500 From: Masaki Ota To: =?utf-8?B?UGFsaSBSb2jDoXI=?= CC: "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dmitry.torokhov@gmail.com" , Aaron Ma Subject: RE: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices Thread-Topic: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices Thread-Index: AQHTXdvFtDMVrRdEUkOSpRi4TAA+pKMVHaqAgAF7ZxA= Date: Thu, 16 Nov 2017 07:27:02 +0000 Message-ID: References: <20171115063404.10066-1-aaron.ma@canonical.com> <20171115083529.jmlpcj4td4evj3xl@pali> In-Reply-To: <20171115083529.jmlpcj4td4evj3xl@pali> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.184.109.136] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;TYXPR01MB0719;20:kVujt88lC2kQOvlY4TSlYcy7aawwKABIsfdzzvA3xhBn+cWHdN9FdzTzngz02g1uMOgBZGfViL3iqho8PRyMa/8rC5M2wUa4BwbLRb54m6K+kbR6Ma7iPazVZLIKhbC8vKHhORFJo+SMV3/OkX2LTA6IzkSBh6rFhoQxJLtFewQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 54327c20-95f2-4853-333a-08d52cc36e47 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603258);SRVR:TYXPR01MB0719; x-ms-traffictypediagnostic: TYXPR01MB0719: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(20558992708506)(9452136761055)(198206253151910)(9931346810618); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231022)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:TYXPR01MB0719;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:TYXPR01MB0719; x-forefront-prvs: 0493852DA9 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(346002)(376002)(189002)(199003)(13464003)(24454002)(81156014)(54356999)(106356001)(42882006)(76176999)(316002)(81166006)(85182001)(305945005)(8676002)(66066001)(14454004)(99286004)(6506006)(53546010)(6916009)(54906003)(3280700002)(9686003)(229853002)(77096006)(55016002)(86362001)(2900100001)(478600001)(5660300001)(105586002)(2950100002)(189998001)(102836003)(3660700001)(4326008)(101416001)(2906002)(7696004)(6246003)(25786009)(7736002)(50986999)(68736007)(97736004)(53936002)(33656002)(74316002)(8936002)(6116002)(6436002)(39060400002)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:TYXPR01MB0719;H:TYXPR01MB0719.jpnprd01.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=masaki.ota@jp.alps.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: jp.alps.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54327c20-95f2-4853-333a-08d52cc36e47 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2017 07:27:02.1010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 57e76998-77bd-4b82-a424-198f46eb2254 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYXPR01MB0719 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAG7RJHU027367 Hi, Pali, Aaron, Current code is correct device setting, previous code is wrong. If the trackstick does not work(DUALPOINT flag disable), Device Firmware setting is wrong. But recently I received the same report from Thinkpad L570 user, and I checked this device and found this device Firmware setting is wrong. Sorry for our mistake. Is your laptop L570 ? I will add code that supports the trackstick for this device. Best Regards, Masaki Ota -----Original Message----- From: Pali Rohár [mailto:pali.rohar@gmail.com] Sent: Wednesday, November 15, 2017 5:35 PM To: 太田 真喜 Masaki Ota Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; dmitry.torokhov@gmail.com; Aaron Ma Subject: Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices On Wednesday 15 November 2017 14:34:04 Aaron Ma wrote: > There is a regression of commit 4a646580f793 ("Input: ALPS - fix > two-finger scroll breakage"), ALPS device fails with log: > > psmouse serio1: alps: Rejected trackstick packet from non DualPoint > device > > ALPS device with id "74 03 28" report OTP[0] data 0xCE after commit > 4a646580f793, after restore the OTP reading order, it becomes to 0x10 > as before and reports the right flag. > > Fixes: 4a646580f793 ("Input: ALPS - fix two-finger scroll breakage") > Cc: > Signed-off-by: Aaron Ma > --- > drivers/input/mouse/alps.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index 579b899add26..c59b8f7ca2fc 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drivers/input/mouse/alps.c > @@ -2562,8 +2562,8 @@ static int alps_set_defaults_ss4_v2(struct > psmouse *psmouse, > > memset(otp, 0, sizeof(otp)); > > - if (alps_get_otp_values_ss4_v2(psmouse, 1, &otp[1][0]) || > - alps_get_otp_values_ss4_v2(psmouse, 0, &otp[0][0])) > + if (alps_get_otp_values_ss4_v2(psmouse, 0, &otp[0][0]) || > + alps_get_otp_values_ss4_v2(psmouse, 1, &otp[1][0])) > return -1; > > alps_update_device_area_ss4_v2(otp, priv); Masaki Ota, please look at this patch as it partially revert your commit 4a646580f793 ("Input: ALPS - fix two-finger scroll breakage"). Something smells here. -- Pali Rohár pali.rohar@gmail.com