RE: [PATCH] x86/speculation: Check whether speculation is force disabled

From: "Tada, Kenta (Sony)" <Kenta.Tada@sony.com>
To: Waiman Long <longman@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
	"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"pawan.kumar.gupta@linux.intel.com" 
	<pawan.kumar.gupta@linux.intel.com>,
	"asteinhauser@google.com" <asteinhauser@google.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>,
	"Tada, Kenta (Sony)" <Kenta.Tada@sony.com>
Subject: RE: [PATCH] x86/speculation: Check whether speculation is force disabled
Date: Wed, 17 Jun 2020 00:15:15 +0000	[thread overview]
Message-ID: <TYXPR01MB1503B0B707C7FB39E25D746AF59A0@TYXPR01MB1503.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <TYXPR01MB150388D14E054374FDB760EDF5860@TYXPR01MB1503.jpnprd01.prod.outlook.com>

I confirmed that this issue was fixed in the below new patch
https://lore.kernel.org/patchwork/patch/1253799/

Thanks.

-----Original Message-----
From: Tada, Kenta (Sony) 
Sent: Friday, June 5, 2020 9:07 PM
To: Waiman Long <longman@redhat.com>; x86@kernel.org; tglx@linutronix.de; mingo@redhat.com; bp@alien8.de; hpa@zytor.com; jpoimboe@redhat.com; peterz@infradead.org; tony.luck@intel.com; pawan.kumar.gupta@linux.intel.com
Cc: linux-kernel@vger.kernel.org
Subject: RE: [PATCH] x86/speculation: Check whether speculation is force disabled

I'm sorry but I could not find the reason of above comments.
I investigated the below log and I thought it was unintentional and the just bug at the moment.
https://lore.kernel.org/lkml/20181125185005.866780996@linutronix.de/

#define PFA_SPEC_IB_FORCE_DISABLE	6	/* Indirect branch speculation permanently restricted */

But the comment of PFA_SPEC_IB_FORCE_DISABLE apparently explains the expected behavior.
And it is only natural that users can force disable the speculation because of security.

I'll investigate more to explain this patch is needed.
Thank you for the review.

-----Original Message-----
From: Waiman Long <longman@redhat.com>
Sent: Friday, June 5, 2020 1:10 AM
To: Tada, Kenta (Sony) <Kenta.Tada@sony.com>; x86@kernel.org; tglx@linutronix.de; mingo@redhat.com; bp@alien8.de; hpa@zytor.com; jpoimboe@redhat.com; peterz@infradead.org; tony.luck@intel.com; pawan.kumar.gupta@linux.intel.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/speculation: Check whether speculation is force disabled

On 6/4/20 3:29 AM, Tada, Kenta (Sony) wrote:
>> It conflicts with your new code. We can have an argument on whether 
>> IB should follow how SSB is being handled. Before that is settled,
> Thank you for the information.
> It conflicts but I think users who read the below document get confused.
> Documentation/userspace-api/spec_ctrl.rst.
>
> Especially, seccomp users must know the difference of this implicit 
> specification because both IB and SSB are force disabled 
> simultaneously when seccomp is enabled without SECCOMP_FILTER_FLAG_SPEC_ALLOW on x86.

What I am saying is that you have to make the argument why your patch is the right way to do thing and also make sure that the comment is consistent. Your current patch doesn't do that.

Cheers,
Longman