From: Andries.Brouwer@cwi.nl
To: Andries.Brouwer@cwi.nl, levon@movementarian.org
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
torvalds@transmeta.com
Subject: Re: [PATCH] kill two scsi ioctls
Date: Thu, 10 Apr 2003 19:29:11 +0200 (MEST) [thread overview]
Message-ID: <UTC200304101729.h3AHTB426607.aeb@smtp.cwi.nl> (raw)
On Thu, Apr 10, 2003 at 06:33:26PM +0200, Andries.Brouwer@cwi.nl wrote:
> The definition for SCSI_IOCTL_BENCHMARK_COMMAND was added in 1.1.2.
> The definition for SCSI_IOCTL_SYNC was added in 1.1.38.
> Neither of them has ever been used.
Can't you at least add a comment about what was there ? It's quite
annoying to come across :
#define FOO 1
#define BAR 2
#define BAZ 5
and have no idea why
It happens all the time. Hundreds of cases.
I prefer a short and clean actual kernel source, and long
historical explanations somewhere else, for example in
Documentation/ioctl_list.
(Michael Elizabeth Chastain made ioctl_list.2 a man page,
but nobody keeps it up-to-date. The current version is from
1.3.27. I am updating it and expect to submit it for the
Documentation directory. Maybe more people will update it there.)
Andries
next reply other threads:[~2003-04-10 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-10 17:29 Andries.Brouwer [this message]
2003-04-10 18:26 ` [PATCH] kill two scsi ioctls John Levon
-- strict thread matches above, loose matches on Subject: below --
2003-04-10 16:33 Andries.Brouwer
2003-04-10 16:38 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200304101729.h3AHTB426607.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).