From: Andries.Brouwer@cwi.nl
To: Andries.Brouwer@cwi.nl, akpm@osdl.org
Cc: aebr@win.tue.nl, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: i_blksize
Date: Tue, 5 Aug 2003 18:27:07 +0200 (MEST) [thread overview]
Message-ID: <UTC200308051627.h75GR7J08241.aeb@smtp.cwi.nl> (raw)
> Looks like I got myself confused
Yes. But nevertheless, now that you brought this up,
we might consider throwing out i_blksize.
I am not aware of anybody who actually uses this to give
per-file advice. So, it could be in the superblock.
There is no reason why it would be a power of two -
the case mentioned yesterday or so was cifs, with
inode->i_blksize =
(pTcon->ses->server->maxBuf - MAX_CIFS_HDR_SIZE) & 0xFFFFFE00;
I see no reason not to replace i_blksize by i_sb->s_optimal_io_size.
Any objections?
If sizeof(struct inode) decreases by 1% then we can keep 1% more inodes.
That reminds me - I threw out i_dev and i_cdev, but Al reintroduced i_cdev.
We should do as some comment says and make a union with i_bdev and i_pipe.
Another 8 bytes gone.
Andries
next reply other threads:[~2003-08-05 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-05 16:27 Andries.Brouwer [this message]
2003-08-05 17:50 ` i_blksize Andrew Morton
2003-08-05 18:09 ` i_blksize Andreas Dilger
-- strict thread matches above, loose matches on Subject: below --
2003-08-05 19:48 i_blksize Andries.Brouwer
2003-08-05 9:20 i_blksize Andries.Brouwer
2003-08-05 15:55 ` i_blksize Andrew Morton
2003-08-04 2:03 do_div considered harmful Andries.Brouwer
2003-08-04 2:29 ` Andrew Morton
2003-08-05 2:58 ` i_blksize Andries Brouwer
2003-08-05 6:10 ` i_blksize Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200308051627.h75GR7J08241.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=aebr@win.tue.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).