From: Andries.Brouwer@cwi.nl
To: der.eremit@email.de, torvalds@osdl.org
Cc: Andries.Brouwer@cwi.nl, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix for ide-scsi crash
Date: Tue, 20 Jan 2004 10:44:27 +0100 (MET) [thread overview]
Message-ID: <UTC200401200944.i0K9iRE25868.aeb@smtp.cwi.nl> (raw)
From torvalds@osdl.org Tue Jan 20 08:33:03 2004
> This patch seems to solve all my 2.6 ide-scsi problems.
I've applied the fix part of it and pushed it out.
Good.
If Andries wants to
re-send the whitespace fixes, I can apply those too, but I hate applying
patches like this where the whitespace fixes hide the real fix.
Yes, it seems we presently have no good mechanism / policy here.
Patches are noise. If some kernel version works and another doesnt,
one has to look at the diffs. Whitespace-only diffs are bad,
I would never submit them. They also needlessly invalidate existing patches.
On the other hand, nice, readable kernel sources are important.
I used to polish the immediate neighbourhood of an actual change.
If that is undesirable, what would you prefer?
> Andrew, you can drop the atapi-mo-support patches from -mm if you
> like. That patch only works with 2048 byte sector discs, while
> the ide-scsi/sd solution also works with 512 and 1024 byte sector
> discs.
I'd really like the ATA cdrom driver to handle different sector sizes
properly. There really is no excuse for a block device driver to hardcode
its blocksize if it can avoid it.
Yes, it is very easy to change that.
And another thing that is very easy is to move partitioning away
from the individual block devices. It was part of the stuff I did
last year. Hope to try again for 2.7.
And then there is the read-only part that must be removed.
Those are three reasons why ide-cd today doesnt work so well
with optical disks. But I am not sure it is desirable to make
ide-cd work with them. The source would be littered with ifs -
all this toc stuff is inappropriate for disks.
Andries
next reply other threads:[~2004-01-20 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 9:44 Andries.Brouwer [this message]
2004-01-20 12:04 ` [PATCH] fix for ide-scsi crash Pascal Schmidt
2004-01-20 13:56 ` Jens Axboe
2004-01-20 17:56 ` Linus Torvalds
2004-01-20 18:46 ` Ben Pfaff
-- strict thread matches above, loose matches on Subject: below --
2004-01-20 17:08 Pascal Schmidt
2004-01-20 20:01 ` Andries Brouwer
2004-01-20 20:58 ` Pascal Schmidt
[not found] <1fMNb-6UA-15@gated-at.bofh.it>
[not found] ` <1fYEB-pz-23@gated-at.bofh.it>
[not found] ` <1g4Ao-60b-25@gated-at.bofh.it>
2004-01-20 14:59 ` Pascal Schmidt
2004-01-20 19:04 ` bill davidsen
2004-01-19 22:56 Andries.Brouwer
2004-01-19 18:51 Pascal Schmidt
2004-01-20 7:32 ` Linus Torvalds
2004-01-20 13:54 ` Jens Axboe
2004-01-19 4:35 Andries.Brouwer
2004-01-19 22:35 ` Willem Riede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200401200944.i0K9iRE25868.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=der.eremit@email.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).