linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Gong <yibin.gong@nxp.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Horia Geanta <horia.geanta@nxp.com>
Cc: "André Draszik" <git@andred.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Anson Huang" <anson.huang@nxp.com>,
	"Aymen Sghaier" <aymen.sghaier@nxp.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 2/3] Input: snvs_pwrkey - enable snvs clock as needed
Date: Tue, 11 Feb 2020 01:54:58 +0000	[thread overview]
Message-ID: <VE1PR04MB6638761F5F8549C6528FE6B989180@VE1PR04MB6638.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200210175554.GB199269@dtor-ws>

On 2020/02/11 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: 
> On Mon, Feb 10, 2020 at 06:33:30AM +0000, Horia Geanta wrote:
> > On 2/10/2020 4:03 AM, Robin Gong wrote:
> > > On 2020/02/10 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > >> On Fri, Feb 07, 2020 at 08:10:22AM +0000, Horia Geanta wrote:
> > >>> On 1/30/2020 10:45 PM, André Draszik wrote:
> > >>>> @@ -140,6 +148,25 @@ static int imx_snvs_pwrkey_probe(struct
> > >> platform_device *pdev)
> > >>>>  	if (pdata->irq < 0)
> > >>>>  		return -EINVAL;
> > >>>>
> > >>>> +	pdata->clk = devm_clk_get(&pdev->dev, "snvs-pwrkey");
> > >>>> +	if (IS_ERR(pdata->clk)) {
> > >>>> +		pdata->clk = NULL;
> > >>> Using devm_clk_get_optional() would simplify error handling.
> > >>
> > >> It sounds to me that this clock is not at all optional and the
> > >> driver currently "works" only by accident and therefore optional is not
> suitable here.
> > > Yes, then we need to add all snvs clk in dts for on legacy i.MX
> > > chips in this patchset to avoid any potential function broken.
> 
> How many are there? I am not too terribly opposed of having the driver handle
> missing clk if there are very many legacy DTSes out there. But then we need to
> handle it properly (i.e. current iteration does not handle referral properly for
> example).
There are four dtsi which have clock support in snvs-rtc  including i.mx7s/i.mx8mq/8mm/8mn. So for this patch set, it's better update
i.mx8mX dtsi except i.mx7s.
> 
> > In that case the DT binding should be updated too, to make the clock
> > mandatory.
> 
> I think this should be done in either case, as as far I understand the part can not
> function without the clock and it worked purely by chance on some systems as
> something else was turning the clock on.
Yes, for all chips snvs clk management added, snvs clock also has to been add
in snvs_pwrkey dts, but for others legacy chips like i.mx6X which have no snvs
clk management, snvs clock is always on, so no need such clk in snvs_pwrkey
dts either, optional is better.
> 
> Thanks.
> 
> --
> Dmitry

  reply	other threads:[~2020-02-11  1:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 20:45 [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey André Draszik
2020-01-30 20:45 ` [PATCH 2/3] Input: snvs_pwrkey - enable snvs clock as needed André Draszik
2020-02-07  8:10   ` Horia Geanta
2020-02-09 22:38     ` Dmitry Torokhov
2020-02-10  2:03       ` Robin Gong
2020-02-10  6:33         ` Horia Geanta
2020-02-10 17:55           ` Dmitry Torokhov
2020-02-11  1:54             ` Robin Gong [this message]
2020-02-11  9:13               ` André Draszik
2020-02-12  0:58                 ` Robin Gong
2020-01-30 20:45 ` [PATCH 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events André Draszik
2020-02-06 18:30 ` [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey Rob Herring
2020-02-07  7:36 ` Horia Geanta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB6638761F5F8549C6528FE6B989180@VE1PR04MB6638.eurprd04.prod.outlook.com \
    --to=yibin.gong@nxp.com \
    --cc=anson.huang@nxp.com \
    --cc=aymen.sghaier@nxp.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=git@andred.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).