From: Robin Gong <yibin.gong@nxp.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"martin.fuzzey@flowbird.group" <martin.fuzzey@flowbird.group>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"matthias.schiffer@ew.tq-group.com"
<matthias.schiffer@ew.tq-group.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script
Date: Thu, 23 Jul 2020 14:11:19 +0000 [thread overview]
Message-ID: <VE1PR04MB6638FFA76076ECCA9CE8F2C289760@VE1PR04MB6638.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <22e53878-42e2-78ed-c460-3fa339c306ad@kontron.de>
On 2020/07/23 19:52 Frieder Schrempf <frieder.schrempf@kontron.de> wrote:
>
> > The warning log comes out during spi
> > transfer start and sdma firmware loading done, but if sdma driver
> > building as module could ensure firmware loading done in
> > sdma_driver_probe_phase-> spi_imx_probe_phase, which means sdma
> > firmware loading has been ready before spi transfer start, hence no such
> warning message.
> >
> > But I am not sure if all client drivers except spi are in good shape
> > to support ' CONFIG_IMX_SDMA=m '.
>
> I'm pretty sure that CONFIG_IMX_SDMA=m is supported and common.
> Otherwise it wouldn't be an option in Kconfig.
Sorry, I mean other drivers using sdma such as audio/uart..etc, I know
sdma driver support to build as module. But I'm not sure if there are some
potential issues here with changing to sdma module. For now, could we
just leave it for another patch whatever it's better solution or not?
>
> > Besides, do you think 'dev_err_once ' instead of 'dev_err' is okay for you?
>
> I can't really judge if this is a proper fix as I haven't looked at the code in detail,
> but if you want to use dev_err_once(), that would be ok for me, maybe even
> better dev_warn_once().
> As chances are that even without firmware transfers will work a warning
> instead of an error makes more sense to me.
Okay, I'll change it in later version. Anyway, thanks for your test.
next prev parent reply other threads:[~2020-07-23 14:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 13:31 [PATCH v10 00/12] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2020-06-30 13:31 ` [PATCH v10 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2020-06-30 13:31 ` [PATCH v10 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2020-06-30 13:31 ` [PATCH v10 03/12] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2020-06-30 13:31 ` [PATCH v10 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Robin Gong
2020-06-30 13:31 ` [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Robin Gong
2020-07-15 5:57 ` Vinod Koul
2020-07-23 9:03 ` Frieder Schrempf
2020-07-23 10:24 ` Robin Gong
2020-07-23 11:12 ` Robin Gong
2020-07-23 11:51 ` Frieder Schrempf
2020-07-23 14:11 ` Robin Gong [this message]
2020-06-30 13:31 ` [PATCH v10 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2020-06-30 13:31 ` [PATCH v10 07/12] spi: imx: fix ERR009165 Robin Gong
2020-06-30 13:31 ` [PATCH v10 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
2020-06-30 13:31 ` [PATCH v10 09/12] spi: imx: add new i.mx6ul compatible name in binding doc Robin Gong
2020-06-30 13:31 ` [PATCH v10 10/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong
2020-06-30 13:31 ` [PATCH v10 11/12] dma: imx-sdma: add i.mx6ul compatible name Robin Gong
2020-06-30 13:31 ` [PATCH v10 12/12] dmaengine: imx-sdma: add uart rom script Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6638FFA76076ECCA9CE8F2C289760@VE1PR04MB6638.eurprd04.prod.outlook.com \
--to=yibin.gong@nxp.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.fuzzey@flowbird.group \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).