From: Roy Im <roy.im.opensource@diasemi.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Roy Im" <roy.im.opensource@diasemi.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Brian Masney <masneyb@onstation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>, Luca Weiss <luca@z3ntu.xyz>,
Maximilian Luz <luzmaximilian@gmail.com>,
Pascal PAILLET-LME <p.paillet@st.com>,
Rob Herring <robh@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Support Opensource <Support.Opensource@diasemi.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: RE: [RESEND PATCH V8 3/3] Input: new da7280 haptic driver
Date: Fri, 14 Feb 2020 01:35:50 +0000 [thread overview]
Message-ID: <VE1PR10MB3085C12BDD9B0713A5A1772785150@VE1PR10MB3085.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20200211142622.5vt34ftdt242agaq@pengutronix.de>
On Tuesday, February 11, 2020 11:26 PM, Uwe Kleine-König wrote
> On Tue, Feb 11, 2020 at 10:13:24AM +0900, Roy Im wrote:
> > diff --git a/drivers/input/misc/da7280.c b/drivers/input/misc/da7280.c
> > new file mode 100644 index 0000000..4d1d1fc
> > --- /dev/null
> > +++ b/drivers/input/misc/da7280.c
> > @@ -0,0 +1,1688 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * DA7280 Haptic device driver
> > + *
> > + * Copyright (c) 2019 Dialog Semiconductor.
> > + * Author: Roy Im <Roy.Im.Opensource@diasemi.com> */
> > +
> > +#include <linux/err.h>
> > +#include <linux/i2c.h>
> > +#include <linux/input.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/module.h>
> > +#include <linux/pwm.h>
> > +#include <linux/regmap.h>
> > +#include <linux/workqueue.h>
> > +#include <linux/uaccess.h>
> > +#include "da7280.h"
>
> Don't introduce a header file that is only used once. Better put the definitions into the c file then.
I will put the definitions into the c file.
>
> > [...]
> > +static int da7280_haptic_set_pwm(struct da7280_haptic *haptics) {
> > + struct pwm_args pargs;
> > + u64 period_mag_multi;
> > + unsigned int pwm_duty;
> > + int error;
> > +
> > + pwm_get_args(haptics->pwm_dev, &pargs);
> > + period_mag_multi =
> > + (u64)(pargs.period * haptics->gain);
>
> This cast does not do anything, does it?
I will remove this.
>
> > + if (haptics->acc_en)
> > + pwm_duty =
> > + (unsigned int)(period_mag_multi >> 16);
> > + else
> > + pwm_duty =
> > + (unsigned int)((period_mag_multi >> 16)
> > + + pargs.period) / 2;
> > +
> > + error = pwm_config(haptics->pwm_dev,
> > + pwm_duty, pargs.period);
> > + if (error) {
> > + dev_err(haptics->dev,
> > + "failed to configure pwm : %d\n", error);
> > + return error;
> > + }
> > +
> > + error = pwm_enable(haptics->pwm_dev);
> > + if (error) {
> > + pwm_disable(haptics->pwm_dev);
> > + dev_err(haptics->dev,
> > + "failed to enable haptics pwm device : %d\n", error);
> > + }
>
> You should not use the legacy pwm API. Please stick to pwm_apply_state().
>
> Also consider using %pE for more expressive error messages.
I will replace the legacy pwm API and stick to pwm_apply_state() and consider using the %pE.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
Hello Uwe,
Thanks for your comments.
I will try to update as you advise.
Best regards,
Roy
next prev parent reply other threads:[~2020-02-14 1:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 1:13 [RESEND PATCH V8 0/3] da7280: haptic driver submission Roy Im
2020-02-11 1:13 ` [RESEND PATCH V8 1/3] MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms Roy Im
2020-02-11 1:13 ` [RESEND PATCH V8 2/3] dt-bindings: input: Add document bindings for DA7280 Roy Im
2020-02-11 1:13 ` [RESEND PATCH V8 3/3] Input: new da7280 haptic driver Roy Im
2020-02-11 14:26 ` Uwe Kleine-König
2020-02-14 1:35 ` Roy Im [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-20 8:26 [RESEND PATCH V8 0/3] da7280: haptic driver submission Roy Im
2019-12-20 8:26 ` [RESEND PATCH V8 3/3] Input: new da7280 haptic driver Roy Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR10MB3085C12BDD9B0713A5A1772785150@VE1PR10MB3085.EURPRD10.PROD.OUTLOOK.COM \
--to=roy.im.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=luzmaximilian@gmail.com \
--cc=masneyb@onstation.org \
--cc=p.paillet@st.com \
--cc=robh@kernel.org \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).