From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754496AbcHVLnV (ORCPT ); Mon, 22 Aug 2016 07:43:21 -0400 Received: from mail-db5eur01on0054.outbound.protection.outlook.com ([104.47.2.54]:13120 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752148AbcHVLnS (ORCPT ); Mon, 22 Aug 2016 07:43:18 -0400 From: Po Liu To: Bjorn Helgaas CC: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Roy Zang , Arnd Bergmann , Marc Zyngier , Stuart Yoder , Yang-Leo Li , Minghuan Lian , Murali Karicheri , "Bjorn Helgaas" , Shawn Guo , Mingkai Hu Subject: RE: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk Thread-Topic: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk Thread-Index: AQHRxheZVDdmrKa9D0uquNOaIWgAJqAwSJ8AgCTimSA= Date: Mon, 22 Aug 2016 10:09:18 +0000 Message-ID: References: <1464242406-20203-1-git-send-email-po.liu@nxp.com> <1465892645-32381-1-git-send-email-po.liu@nxp.com> <1465892645-32381-2-git-send-email-po.liu@nxp.com> <20160729224154.GC13632@localhost> In-Reply-To: <20160729224154.GC13632@localhost> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=po.liu@nxp.com; x-originating-ip: [199.59.225.131] x-ms-office365-filtering-correlation-id: 2f8a8c18-f9f3-42f3-9a09-08d3ca74611a x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2637;6:iX9crEVJIholWOwDnG/CKONfWwlf4WhrmQ29JNAlLnoAWhJbW7EnNujKgZyANOkQC8X+rf3QotR2V8cMHTbdSJsRxRsLt6/xapZc74eGxNR5UCnV2Y9M8ntRCC3vfToaBHNqkVrXa+qJyuBLQbhN5Rsp+w/+Jj1gZuu8l/ym5DBOvQKJAtx7cAe+w+JQrxASVSURKVKDOWkwKnVha1DX9iEjAcZ5ABqR6TwWtlXCz+7yhWvLRRHPLZfOto7q86o+ukXSQTgBcnACYbRwwvYDCxbTLOI2ld5t6bZJrE4aC2tRebwpD4kejgWP5bNepU/F+8PWkAQMOQD6vHOSw2XnOQ==;5:fIcY9TedkCCLUPf3OpTbtn4Okaa1bvvnzUx3KiJe0xTTYEd71LfXOGaR98q0IaSBNwxdxGjlHiUY/DrhiDBauZP+RggeeA6aNSASMW1rbPgCl24SAWznwsLQ0ILiTIm9gNRy5UVCj0B0e+XIsgmUDg==;24:7M/PM733d3H0MSSTg56Ve3LLH0w4qXa5d3a0prK/dc3mLYgLDNRFyKBP3AyfyWakmCmA5qqVsdH/wiyuDUjyNoMiNwaB0XWfOswH2jkQbVs=;7:E5Srvw8Kohth1hyK4ImaN1N7o1ZeWzBzr3T0rikuQHKA77ntgmT13ROoG/n7ZYUOG617DqdHmhHKJNOZcBWFjVXcrFHgVk5sesGoVsioGHFxUQNNm8Ddy/f4/6x6v7WMtAu1RBgm+QWc8meyWEiVbCG+gQKeLW60Wofsm8M+AjTcIsNEcbbLB3nqUljhsMTe6H+6vn+FJTg+DYi8A3aluxKEUIxnR/5Xp7FY2lADkPdt6JkLjhKNlVWE9rWhz7Dq x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2637; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:VI1PR0401MB2637;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2637; x-forefront-prvs: 00429279BA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(377454003)(199003)(24454002)(13464003)(3846002)(7846002)(97736004)(19580405001)(8936002)(68736007)(586003)(106356001)(7736002)(76576001)(19580395003)(7416002)(33656002)(305945005)(122556002)(81166006)(81156014)(8676002)(7696003)(3280700002)(9686002)(3660700001)(15975445007)(77096005)(5660300001)(74316002)(1720100001)(66066001)(50986999)(102836003)(86362001)(92566002)(101416001)(189998001)(105586002)(5002640100001)(6116002)(54356999)(10400500002)(2950100001)(93886004)(2906002)(76176999)(2900100001)(4326007)(106116001)(110136002)(87936001)(11100500001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2637;H:VI1PR0401MB1709.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2016 10:09:18.1060 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2637 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7MBhQmS014255 Hi Bjorn, Sorry for late reply. I checked the updated kernel with Dongdong mentioned ACPI patch which was truly affected my quirk patch uploaded. So I suppose the quirk patch is not qualify to fix the bug. I were keep thinking what your "explicitly checking for a root port device" meaning. Do you mean I should upload again the first version patch which fix it in the portdrv_core.c ? I would upload again if yes. Thanks! Best regards, Liu Po > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: Saturday, July 30, 2016 6:42 AM > To: Po Liu > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Roy Zang; Arnd > Bergmann; Marc Zyngier; Stuart Yoder; Yang-Leo Li; Minghuan Lian; Murali > Karicheri; Bjorn Helgaas; Shawn Guo; Mingkai Hu > Subject: Re: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk > > On Tue, Jun 14, 2016 at 04:24:05PM +0800, Po Liu wrote: > > On some platforms, root port doesn't support MSI/MSI-X/INTx in RC mode. > > When chip support the aer interrupt with none MSI/MSI-X/INTx mode, > > maybe there is interrupt line for aer pme etc. Search the interrupt > > number in the fdt file. Then fixup the dev->irq with it. > > > > Signed-off-by: Po Liu > > I'm not sure where we're at with this. Dongdong had some issue > (possibly with a version of the quirk on a different platform?), and I > think the suggestion of explicitly checking for a root port device was a > good one. > > So please update and repost this for next cycle. > > > --- > > changes for V3: > > - Move to quirk; > > - Only correct the irq in RC mode; > > > > drivers/pci/quirks.c | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index > > ee72ebe..8b39cce 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -25,6 +25,7 @@ > > #include > > #include > > #include > > +#include > > #include /* isa_dma_bridge_buggy */ > > #include "pci.h" > > > > @@ -4419,3 +4420,31 @@ static void quirk_intel_qat_vf_cap(struct > pci_dev *pdev) > > } > > } > > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x443, > > quirk_intel_qat_vf_cap); > > + > > +/* If root port doesn't support MSI/MSI-X/INTx in RC mode, > > + * but use standalone irq. Read the device tree for the aer > > + * interrupt number. > > + */ > > +static void quirk_aer_interrupt(struct pci_dev *dev) { > > + int ret; > > + u8 header_type; > > + struct device_node *np = NULL; > > + > > + /* Only for the RC mode device */ > > + pci_read_config_byte(dev, PCI_HEADER_TYPE, &header_type); > > + if ((header_type & 0x7F) != PCI_HEADER_TYPE_BRIDGE) > > + return; > > + > > + if (dev->bus->dev.of_node) > > + np = dev->bus->dev.of_node; > > + > > + if (IS_ENABLED(CONFIG_OF_IRQ) && np) { > > + ret = of_irq_get_byname(np, "aer"); > > + if (ret > 0) { > > + dev->no_msi = 1; > > + dev->irq = ret; > > + } > > + } > > +} > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, > > +quirk_aer_interrupt); > > -- > > 2.1.0.27.g96db324 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel