From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "stuyoder@gmail.com" <stuyoder@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"arnd@arndb.de" <arnd@arndb.de>, Roy Pledge <roy.pledge@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"agraf@suse.de" <agraf@suse.de>,
"Catalin Horghidan" <catalin.horghidan@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Leo Li <leoyang.li@nxp.com>,
Bharat Bhushan <bharat.bhushan@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens
Date: Tue, 6 Jun 2017 12:03:51 +0000 [thread overview]
Message-ID: <VI1PR0401MB185672AD42A817013EB27CAFECCB0@VI1PR0401MB1856.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20170603084126.GB10784@kroah.com>
Hi Greg,
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Saturday, June 03, 2017 11:41 AM
>
> On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Several macros didn't had macro params enclosed in parens. Fix them to
> > avoid precedence issues.
> >
> > Found with checkpatch.pl who was issuing this
> > message:
> > "Macro argument 'id' may be better as '(id)'
> > to avoid precedence issues"
>
> Why are you line-wrapping at such a small number? Please use 72 columns like
> git asks you to...
I'll rewrap the commit message in the next spin.
---
Thanks & Best Regards, Laurentiu
next prev parent reply other threads:[~2017-06-06 12:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 10:58 [PATCH v6 00/10] staging: fsl-mc: move bus driver out of staging laurentiu.tudor
2017-05-31 10:58 ` [PATCH 01/10] staging: fsl-mc: enclose macro params in parens laurentiu.tudor
2017-06-03 8:41 ` Greg KH
2017-06-06 12:03 ` Laurentiu Tudor [this message]
2017-05-31 10:58 ` [PATCH 02/10] staging: fsl-mc: fix macros with possible side effects laurentiu.tudor
2017-05-31 10:58 ` [PATCH 03/10] staging: fsl-mc: simplify couple of deallocations laurentiu.tudor
2017-05-31 10:58 ` [PATCH 04/10] staging: fsl-mc: drop a few useless #includes laurentiu.tudor
2017-05-31 10:58 ` [PATCH 05/10] staging: fsl-mc: remove extra blank line laurentiu.tudor
2017-05-31 10:58 ` [PATCH 06/10] staging: fsl-mc: drop unused forward declaration laurentiu.tudor
2017-05-31 10:58 ` [PATCH v2 07/10] staging: fsl-mc: add binding path to MAINTAINERS laurentiu.tudor
2017-05-31 10:58 ` [PATCH 08/10] staging: fsl-mc: drop reference to restool laurentiu.tudor
2017-05-31 10:58 ` [PATCH 09/10] staging: fsl-mc: add reference to mc-bus DT binding laurentiu.tudor
2017-05-31 10:58 ` [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging laurentiu.tudor
2017-05-31 11:15 ` Marc Zyngier
2017-05-31 11:31 ` Laurentiu Tudor
2017-06-03 8:40 ` Greg KH
2017-06-06 14:03 ` Laurentiu Tudor
2017-06-06 14:20 ` Greg KH
2017-06-06 14:23 ` Laurentiu Tudor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB185672AD42A817013EB27CAFECCB0@VI1PR0401MB1856.eurprd04.prod.outlook.com \
--to=laurentiu.tudor@nxp.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bharat.bhushan@nxp.com \
--cc=catalin.horghidan@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.pledge@nxp.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).