From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761453AbdACV06 (ORCPT ); Tue, 3 Jan 2017 16:26:58 -0500 Received: from mail-db5eur01on0048.outbound.protection.outlook.com ([104.47.2.48]:6656 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757679AbdACV0v (ORCPT ); Tue, 3 Jan 2017 16:26:51 -0500 From: Stuart Yoder To: Greg KH CC: "devel@driverdev.osuosl.org" , "arnd@arndb.de" , Roy Pledge , Alexandru Marginean , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , "Bogdan Hamciuc" , Laurentiu Tudor Subject: RE: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file Thread-Topic: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file Thread-Index: AQHST6P8gLAcyQr7sk6cziYpfvtUZaD6rywAgAACWoCAAAPcAIAAJqoQgABYp4CAAANakIAr6uMAgABIJDA= Date: Tue, 3 Jan 2017 21:26:46 +0000 Message-ID: References: <20161206093442.11362-1-ruxandra.radulescu@nxp.com> <20161206093442.11362-8-ruxandra.radulescu@nxp.com> <20161206095800.GA4247@kroah.com> <20161206102014.GA7899@kroah.com> <20161206175555.GB15607@kroah.com> <20170103164746.GA24790@kroah.com> In-Reply-To: <20170103164746.GA24790@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=stuart.yoder@nxp.com; x-originating-ip: [192.88.168.50] x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2653;7:uEH27jxHMnsAcKXkHtNLaTeeUzE9XluplhhTuPTNz72JcUnRlOmvSfiRvT2Ne6gN0fZrvJBSl7z7YfKe0aFvjoD5c1FEQdmiGWGP+6GGIJDjNQS3U9joRhpqzaxFIXO1/Jg6l16EhGZm74ukztLz7o3HaAj3UYS59T2MXrmHigYqzUGZDipacIbCN1iHDaVNO4FP1wd4TmhM/z4PG8XMDtznfd/oLxa6LQotHoxSqRpnLOjA0T+h4wF+NUpt/e1zaqdp8xRy8JEZ6boqdIdz/4KVXtkQX8qXMRwDuqPnBGu75gOTt/g+GWBbUCH8i62OcTt/dM5jwUScuzlfAfuShnxN0DMnbXRIiUVvjaFEyZ8qfJHeOyGgayT/yS4/EzYU6x0qjHQT1BcvzA6sigobKYfIJn8cLR8wpetcFR9n7N4qBK8nRJV+fxBzLLuKKMumZ2d2b+GOzkP5JfvfHrkH8g== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39860400002)(39840400002)(39450400003)(39850400002)(24454002)(189002)(13464003)(377454003)(199003)(66066001)(3846002)(2900100001)(93886004)(86362001)(54906002)(7736002)(229853002)(7696004)(101416001)(5660300001)(110136003)(305945005)(106116001)(54356999)(105586002)(76176999)(81156014)(8936002)(81166006)(189998001)(9686002)(2950100002)(6916009)(25786008)(122556002)(33656002)(8676002)(106356001)(2906002)(99286003)(55016002)(97736004)(74316002)(6506006)(6436002)(6116002)(3660700001)(102836003)(3280700002)(4326007)(92566002)(50986999)(38730400001)(77096006)(68736007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2653;H:VI1PR0401MB2638.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-correlation-id: 28114283-fcca-4b88-b7ff-08d4341f388c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR0401MB2653; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148)(6047074);SRVR:VI1PR0401MB2653;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2653; x-forefront-prvs: 01762B0D64 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2017 21:26:46.1367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2653 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v03LR2US016015 > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, January 03, 2017 10:48 AM > To: Stuart Yoder > Cc: devel@driverdev.osuosl.org; arnd@arndb.de; Roy Pledge ; Alexandru Marginean > ; linux-kernel@vger.kernel.org; agraf@suse.de; Bogdan Hamciuc > ; Laurentiu Tudor > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > On Tue, Dec 06, 2016 at 06:10:38PM +0000, Stuart Yoder wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > Sent: Tuesday, December 06, 2016 11:56 AM > > > To: Stuart Yoder > > > Cc: Ruxandra Ioana Radulescu ; devel@driverdev.osuosl.org; linux- > > > kernel@vger.kernel.org; agraf@suse.de; arnd@arndb.de; Alexandru Marginean > ; > > > Bogdan Hamciuc ; Roy Pledge ; Laurentiu Tudor > > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > On Tue, Dec 06, 2016 at 12:59:59PM +0000, Stuart Yoder wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > > Sent: Tuesday, December 06, 2016 4:20 AM > > > > > To: Ruxandra Ioana Radulescu > > > > > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; agraf@suse.de; arnd@arndb.de; > > > Alexandru > > > > > Marginean ; Bogdan Hamciuc ; Stuart Yoder > > > > > ; Roy Pledge ; Laurentiu Tudor > > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > > > > > On Tue, Dec 06, 2016 at 10:06:25AM +0000, Ruxandra Ioana Radulescu wrote: > > > > > > > -----Original Message----- > > > > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > > > > Sent: Tuesday, December 06, 2016 11:58 AM > > > > > > > To: Ruxandra Ioana Radulescu > > > > > > > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; > > > > > > > agraf@suse.de; arnd@arndb.de; Alexandru Marginean > > > > > > > ; Bogdan Hamciuc > > > > > > > ; Stuart Yoder ; Roy > > > > > > > Pledge ; Laurentiu Tudor > > > > > > > > > > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > > > > > > > > > On Tue, Dec 06, 2016 at 03:34:41AM -0600, Ioana Radulescu wrote: > > > > > > > > Add a list of TODO items for the Ethernet driver > > > > > > > > > > > > > > > > Signed-off-by: Ioana Radulescu > > > > > > > > --- > > > > > > > > drivers/staging/fsl-dpaa2/ethernet/TODO | 9 +++++++++ > > > > > > > > 1 files changed, 9 insertions(+), 0 deletions(-) > > > > > > > > create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO > > > > > > > > > > > > > > > > diff --git a/drivers/staging/fsl-dpaa2/ethernet/TODO b/drivers/staging/fsl- > > > > > > > dpaa2/ethernet/TODO > > > > > > > > new file mode 100644 > > > > > > > > index 0000000..833265b > > > > > > > > --- /dev/null > > > > > > > > +++ b/drivers/staging/fsl-dpaa2/ethernet/TODO > > > > > > > > @@ -0,0 +1,9 @@ > > > > > > > > +* Add a DPAA2 MAC kernel driver in order to allow PHY management; > > > > > > > currently > > > > > > > > + the DPMAC objects and their link to DPNIs are handled by MC internally > > > > > > > > + and all PHYs are seen as fixed-link > > > > > > > > +* add more debug support: decide how to expose detailed debug > > > > > > > statistics, > > > > > > > > + add ingress error queue support > > > > > > > > +* MC firmware uprev; the DPAA2 objects used by the Ethernet driver > > > > > > > need to > > > > > > > > + be kept in sync with binary interface changes in MC > > > > > > > > +* refine README file > > > > > > > > +* cleanup > > > > > > > > > > > > > > These seem like very minor things, why not just spend a week and do this > > > > > > > work and get it merged to the "correct" portion of the kernel tree? Why > > > > > > > does this have to go into staging? > > > > > > > > > > > > Actually the first bullet is not minor at all and requires some design > > > > > > choices that we aren't yet completely clear with, and which in turn may > > > > > > affect parts of the Ethernet driver. We figured it would be best to try > > > > > > adding this in staging first (and also provide this way an example of using > > > > > > the fsl-mc bus and dpio driver) than wait until all MAC development > > > > > > questions are ironed-out. > > > > > > > > > > Ok, that makes sense. > > > > > > > > > > > I can remove the other bullets from the TODO list if you think they're > > > > > > not worth mentioning. > > > > > > > > > > No, they should be mentioned, I just didn't think they are all that much > > > > > work, and if you didn't have major things needed to get done, you could > > > > > just knock it all out in a week of local development. > > > > > > > > > > I'll look into taking this into the tree later today... > > > > > > > > Note, as mentioned in the cover letter, in it's current form this patch > > > > series is based on the series: > > > > [PATCH v3 0/9] staging: fsl-mc: move bus driver out of staging, add dpio > > > > > > > > ...which means that it won't build or run without that series being > > > > applied first, due to header file dependencies. It also functionally > > > > depends on the DPIO driver. So we need the dpio driver merged first. > > > > > > > > Is moving the fsl-mc bus driver out of staging a possibility now? > > > > > > I'm ok with it, but I really haven't looked at the patches in a while, I > > > keep seeing others have problems with it. Want me to review it now? > > > > Yes, would like that very much. > > Ok, basic driver model things, who is cleaning up your struct devices > when they go away? Don't you get nasty warnings from the driver core > when the device is removed? Thanks, you had some similar comments back in December: https://lkml.org/lkml/2016/12/8/364 Device removal works, but we are not getting warnings because the ref count never goes to zero...so something is wrong and we are debugging and will refactoring. > And you can't allocate a 'struct device' with devm_kzalloc(), that's > just crazy as the lifetime can not be owned by someone else for a > refernce counted object! > > And finally, no one is calling dpmcp_destroy(), why is it there? Looks not to be needed...will that and any other functions that are not called. > I think this needs a lot of driver model rework, sorry. Please do that > before adding new drivers. Yes, work is in progress. Thanks, Stuart