From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev-owner@vger.kernel.org" <netdev-owner@vger.kernel.org>,
Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
Horia Geanta <horia.geanta@nxp.com>, Leo Li <leoyang.li@nxp.com>
Subject: RE: [PATCH v3 2/4] bus: fsl-mc: add fsl-mc userspace support
Date: Tue, 20 Nov 2018 16:51:07 +0000 [thread overview]
Message-ID: <VI1PR0402MB2800CF10719D11DD21F47356E0D90@VI1PR0402MB2800.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181120164416.GB27531@kroah.com>
> On Tue, Nov 20, 2018 at 03:39:45PM +0000, Ioana Ciornei wrote:
> > +
> > + error = fsl_mc_uapi_create_device_file(mc_bus);
> > + if (error < 0) {
> > + error = -EPROBE_DEFER;
> > + goto error_cleanup_msi_domain;
> > + }
>
> What error could occur here that would be somehow fixed if you defer and try
> this all again? Shouldn't you just return the error given (as something really went
> wrong here, it's not a "something else needs to start up first issue), and abort?
>
It's really a "something else needs to start up first" type of issue. The fsl_mc_uapi_create_device_file fails only if the misc_register fails and this could really happen when the misc char driver is not yet initialized.
Initially, I have used the register_chrdev API and you suggested to use a misc device and just defer probe if it's not yet initialized.
Ioana C
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2018-11-20 16:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 15:39 [PATCH v3 0/4] bus: fsl-mc: enhance Management Complex userspace support Ioana Ciornei
2018-11-20 15:39 ` [PATCH v3 1/4] bus: fsl-mc: move fsl_mc_command struct in a uapi header Ioana Ciornei
2018-11-20 15:39 ` [PATCH v3 2/4] bus: fsl-mc: add fsl-mc userspace support Ioana Ciornei
2018-11-20 16:44 ` gregkh
2018-11-20 16:51 ` Ioana Ciornei [this message]
2018-11-20 16:58 ` gregkh
2018-11-20 16:48 ` gregkh
2018-11-20 17:59 ` Ioana Ciornei
2018-11-21 8:14 ` gregkh
2018-11-29 16:55 ` Ioana Ciornei
2018-11-20 15:39 ` [PATCH v3 3/4] bus: fsl-mc: add root dprc rescan attribute Ioana Ciornei
2018-11-20 15:39 ` [PATCH v3 4/4] bus: fsl-mc: add bus " Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB2800CF10719D11DD21F47356E0D90@VI1PR0402MB2800.eurprd04.prod.outlook.com \
--to=ioana.ciornei@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=horia.geanta@nxp.com \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-owner@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).