linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan-gabriel Mirea <stefan-gabriel.mirea@nxp.com>
To: Will Deacon <will@kernel.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	Leo Li <leoyang.li@nxp.com>, "jslaby@suse.com" <jslaby@suse.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Cosmin Stefan Stoica <cosmin.stoica@nxp.com>,
	Larisa Ileana Grigore <larisa.grigore@nxp.com>
Subject: Re: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234
Date: Thu, 8 Aug 2019 12:47:00 +0000	[thread overview]
Message-ID: <VI1PR0402MB28635661A4A294EC6F01095EDFD70@VI1PR0402MB2863.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190808080832.nleult5bknmzr3ze@willie-the-truck

Hello Will,

On 8/8/2019 11:08 AM, Will Deacon wrote:
> On Fri, Aug 02, 2019 at 07:47:23PM +0000, Stefan-gabriel Mirea wrote:
>> +             linflex,<addr>
>> +                     Use early console provided by Freescale LinFlex UART
>> +                     serial driver for NXP S32V234 SoCs. A valid base
>> +                     address must be provided, and the serial port must
>> +                     already be setup and configured.
> 
> Why isn't earlycon= sufficient for this?

"earlycon=" is not actually supported. I will fix this in the next
version by adding a /chosen/stdout-path to the dts. The compatible
string provided to OF_EARLYCON_DECLARE will also be changed from
"fsl,s32v234-linflexuart" to "fsl,s32-linflexuart" to match the one in
the device tree nodes. I missed this after importing a rename from our
codebase.

Should I remove this addition from kernel-parameters.txt after that?

Regards,
Stefan

  reply	other threads:[~2019-08-08 12:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 19:47 [PATCH 0/6] Add initial support for S32V234-EVB Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board Stefan-gabriel Mirea
2019-08-02 22:38   ` Rob Herring
2019-08-03  8:00     ` [EXT] " Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 2/6] arm64: Introduce config for S32 Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 3/6] arm64: dts: fsl: Add device tree for S32V234-EVB Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 4/6] dt-bindings: serial: Document Freescale LINFlex UART Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234 Stefan-gabriel Mirea
2019-08-05 15:31   ` gregkh
2019-08-06 17:11     ` Stefan-gabriel Mirea
2019-08-06 18:40       ` gregkh
2019-08-07 16:42         ` Stefan-gabriel Mirea
2019-08-07 16:56           ` gregkh
2019-08-07 17:05             ` Stefan-gabriel Mirea
2019-08-08  8:08   ` Will Deacon
2019-08-08 12:47     ` Stefan-gabriel Mirea [this message]
2019-08-08 17:17       ` Will Deacon
2019-08-09  9:45         ` Stefan-gabriel Mirea
2019-08-09  9:53           ` Will Deacon
2019-08-09  9:57             ` Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 6/6] arm64: defconfig: Enable configs " Stefan-gabriel Mirea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0402MB28635661A4A294EC6F01095EDFD70@VI1PR0402MB2863.eurprd04.prod.outlook.com \
    --to=stefan-gabriel.mirea@nxp.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=cosmin.stoica@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=larisa.grigore@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).