From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbdAVBes (ORCPT ); Sat, 21 Jan 2017 20:34:48 -0500 Received: from mail-he1eur01on0087.outbound.protection.outlook.com ([104.47.0.87]:24204 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750889AbdAVBep (ORCPT ); Sat, 21 Jan 2017 20:34:45 -0500 From: Peter Chen To: Stephen Boyd , Kishon Vijay Abraham I CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , Andy Gross , "Bjorn Andersson" , Neil Armstrong , Arnd Bergmann , Felipe Balbi , "linux-usb@vger.kernel.org" Subject: RE: [PATCH v7 3/5] phy: Add set_vbus callback Thread-Topic: [PATCH v7 3/5] phy: Add set_vbus callback Thread-Index: AQHSc04nH7ohT0bgPUW7RqQ+5dpMAqFDuF+A Date: Sun, 22 Jan 2017 01:34:40 +0000 Message-ID: References: <20170120185057.16206-1-stephen.boyd@linaro.org> <20170120185057.16206-4-stephen.boyd@linaro.org> In-Reply-To: <20170120185057.16206-4-stephen.boyd@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-originating-ip: [192.158.241.86] x-ms-office365-filtering-correlation-id: 3510979c-f449-4343-232b-08d44266d5b2 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR04MB1456; x-microsoft-exchange-diagnostics: 1;VI1PR04MB1456;7:sNkPF18MG94a/hdLgBqEuYpD6arc1D+OZ780leBeQ4UfkjwXuyF5Fc60HK+uo+tkaZYlpibWpLRa0r8hE0icTV70+PzOnYXvfwNKijizspHYjiNcEqXpVOpErJBqUjFGC+CoEEhqKO+8o3Jxvy4jzZLvxvn0HE+p72QjTSOXEzOI+Xi3xUjnB9ng0t/ENujhtg2xZvQ8yf/FF010R9G+w6lwPYvjOjAwtNZuVbw+t3t/K0iMQXqSe2NsZMRu++6ontkIXUkYwB2wu/Fwx4GfDwfAl4K7cSchfJGhITdmSwtps9EOdAupnRW/xMMpp9bH7D+xIYqAWGADwf0UuIHPKmHlP93kS4yfpaouEJ2M9ZOIAjBd0zEk1T0ABKaomU4R1oTnOVOnmaIzE/lq4wDD5sIxm9SBnpFEzvLLkLM8ubGr3Yon+E2AIHCkxtcO+W6HJECRcVGjqMtIDmsSbjZPjw== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148)(6047074);SRVR:VI1PR04MB1456;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB1456; x-forefront-prvs: 01952C6E96 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39840400002)(39860400002)(39450400003)(39850400002)(199003)(189002)(6116002)(6506006)(102836003)(68736007)(66066001)(7416002)(53936002)(101416001)(3660700001)(92566002)(81156014)(3846002)(99286003)(4326007)(2950100002)(81166006)(305945005)(7696004)(122556002)(38730400001)(55016002)(2900100001)(50986999)(54356999)(7736002)(76176999)(8676002)(229853002)(77096006)(33656002)(9686003)(3280700002)(25786008)(97736004)(2906002)(189998001)(8936002)(5001770100001)(54906002)(105586002)(6436002)(106116001)(86362001)(106356001)(5660300001)(74316002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB1456;H:VI1PR04MB1455.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2017 01:34:40.3779 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1456 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0M1Z33h001012 > * @set_mode: set the mode of the phy >+ * @set_vbus: enable/disable vbus in the phy (USB) > * @reset: resetting the phy > * @owner: the module owner containing the ops > */ >@@ -45,6 +46,7 @@ struct phy_ops { > int (*power_on)(struct phy *phy); > int (*power_off)(struct phy *phy); > int (*set_mode)(struct phy *phy, enum phy_mode mode); >+ int (*set_vbus)(struct phy *phy, int on); How about using the name notify_vbus? The main purpose of this API is notify PHY vbus status. Peter