From: Yinbo Zhu <yinbo.zhu@nxp.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Xiaobo Xie <xiaobo.xie@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ramneek Mehresh <ramneek.mehresh@freescale.com>,
Nikhil Badola <nikhil.badola@freescale.com>,
Ran Wang <ran.wang_1@nxp.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiafei Pan <jiafei.pan@nxp.com>,
Suresh Gupta <suresh.gupta@freescale.com>
Subject: RE: [EXT] Re: [PATCH v5 4/5] usb: host: Stops USB controller init if PLL fails to lock
Date: Thu, 9 May 2019 03:58:04 +0000 [thread overview]
Message-ID: <VI1PR04MB4158AA40AB4A4E60711FD580E9330@VI1PR04MB4158.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1905081248440.1699-100000@iolanthe.rowland.org>
> -----Original Message-----
> From: Alan Stern [mailto:stern@rowland.harvard.edu]
> Sent: 2019年5月9日 0:50
> To: Yinbo Zhu <yinbo.zhu@nxp.com>
> Cc: Xiaobo Xie <xiaobo.xie@nxp.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Ramneek Mehresh
> <ramneek.mehresh@freescale.com>; Nikhil Badola
> <nikhil.badola@freescale.com>; Ran Wang <ran.wang_1@nxp.com>;
> linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Jiafei Pan
> <jiafei.pan@nxp.com>; Suresh Gupta <suresh.gupta@freescale.com>
> Subject: [EXT] Re: [PATCH v5 4/5] usb: host: Stops USB controller init if PLL fails to
> lock
>
> Caution: EXT Email
>
> On Wed, 8 May 2019, Yinbo Zhu wrote:
>
> > From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> >
> > USB erratum-A006918 workaround tries to start internal PHY inside
> > uboot (when PLL fails to lock). However, if the workaround also fails,
> > then USB initialization is also stopped inside Linux.
> > Erratum-A006918 workaround failure creates "fsl,erratum_a006918"
> > node in device-tree. Presence of this node in device-tree is used to
> > stop USB controller initialization in Linux
> >
> > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> > Signed-off-by: Suresh Gupta <suresh.gupta@freescale.com>
> > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> > ---
> > Change in v5:
> > use dev_warn() instead of pr_warn()
> >
> > drivers/usb/host/ehci-fsl.c | 5 +++++
> > drivers/usb/host/fsl-mph-dr-of.c | 3 ++-
> > 2 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> > index 1634ac8..90550a6 100644
> > --- a/drivers/usb/host/ehci-fsl.c
> > +++ b/drivers/usb/host/ehci-fsl.c
> > @@ -236,6 +236,11 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
> > portsc |= PORT_PTS_PTW;
> > /* fall through */
> > case FSL_USB2_PHY_UTMI:
> > + if (pdata->has_fsl_erratum_a006918) {
> > + dev_warn(dev, "USB PHY clock invalid\n");
> > + return -EINVAL;
> > + }
> > +
>
> You need to add a "Fall through" comment between these two cases.
> > case FSL_USB2_PHY_UTMI_DUAL:
> > /* PHY_CLK_VALID bit is de-featured from all controller
> > * versions below 2.4 and is to be checked only for
>
> Alan Stern
Hi Alan Stern,
Your meaning is to remove "/* fall through*/" or add the erratum commont replace "/* fall through*/"
Regards,
Yinbo
next prev parent reply other threads:[~2019-05-09 3:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 6:04 [PATCH v5 1/5] usb: fsl: Set USB_EN bit to select ULPI phy Yinbo Zhu
2019-05-08 6:04 ` [PATCH v5 2/5] usb: phy: Workaround for USB erratum-A005728 Yinbo Zhu
2019-05-08 14:15 ` Alan Stern
2019-05-09 3:54 ` [EXT] " Yinbo Zhu
2019-05-08 6:04 ` [PATCH v5 3/5] usb: linux/fsl_device: Add platform member has_fsl_erratum_a006918 Yinbo Zhu
2019-05-08 6:04 ` [PATCH v5 4/5] usb: host: Stops USB controller init if PLL fails to lock Yinbo Zhu
2019-05-08 16:50 ` Alan Stern
2019-05-09 3:58 ` Yinbo Zhu [this message]
2019-05-08 6:04 ` [PATCH v5 5/5] usb :fsl: Change string format for errata property Yinbo Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB4158AA40AB4A4E60711FD580E9330@VI1PR04MB4158.eurprd04.prod.outlook.com \
--to=yinbo.zhu@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiafei.pan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nikhil.badola@freescale.com \
--cc=ramneek.mehresh@freescale.com \
--cc=ran.wang_1@nxp.com \
--cc=stern@rowland.harvard.edu \
--cc=suresh.gupta@freescale.com \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).