From: Aisheng Dong <aisheng.dong@nxp.com>
To: Abel Vesa <abel.vesa@nxp.com>, Robin Gong <yibin.gong@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Stefan Agner <stefan@agner.ch>,
Linus Walleij <linus.walleij@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] pinctrl: pinctrl-imx8mq: Add support PM operations
Date: Thu, 4 Apr 2019 06:51:25 +0000 [thread overview]
Message-ID: <VI1PR04MB422278BD9C029E7332BB3C0A80500@VI1PR04MB4222.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1553522352-20214-2-git-send-email-abel.vesa@nxp.com>
> From: Abel Vesa
> Sent: Monday, March 25, 2019 10:00 PM
>
> Add suspend/resume pm ops to the pinctrl i.MX8MQ driver.
> Make the suspend late and the resume early since some of the pins might be
> needed active very late.
> These call the pinctrl-imx generic handlers.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> drivers/pinctrl/freescale/pinctrl-imx8mq.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx8mq.c
> b/drivers/pinctrl/freescale/pinctrl-imx8mq.c
> index 8d39af5..2a212bc 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx8mq.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx8mq.c
> @@ -335,10 +335,26 @@ static int imx8mq_pinctrl_probe(struct
> platform_device *pdev)
> return imx_pinctrl_probe(pdev, &imx8mq_pinctrl_info); }
>
> +static int imx8mq_pinctrl_suspend(struct device *dev) {
> + return imx_pinctrl_suspend(dev);
> +}
> +
> +static int imx8mq_pinctrl_resume(struct device *dev) {
> + return imx_pinctrl_resume(dev);
> +}
> +
> +static const struct dev_pm_ops imx8mq_pinctrl_pm_ops = {
It looks we did not nothing special on the dev_pm_ops for platform drivers.
So do you think if we can move this into common pinctrl-imx.c?
Then platform driver does not need to implement the duplicated things?
Regards
Dong Aisheng
> + SET_LATE_SYSTEM_SLEEP_PM_OPS(imx8mq_pinctrl_suspend,
> + imx8mq_pinctrl_resume)
> +};
> +
> static struct platform_driver imx8mq_pinctrl_driver = {
> .driver = {
> .name = "imx8mq-pinctrl",
> .of_match_table = of_match_ptr(imx8mq_pinctrl_of_match),
> + .pm = &imx8mq_pinctrl_pm_ops,
> .suppress_bind_attrs = true,
> },
> .probe = imx8mq_pinctrl_probe,
> --
> 2.7.4
prev parent reply other threads:[~2019-04-04 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 13:59 [PATCH v2 1/2] pinctrl: pinctrl-imx: Add suspend/resume for LPSR Abel Vesa
2019-03-25 13:59 ` [PATCH v2 2/2] pinctrl: pinctrl-imx8mq: Add support PM operations Abel Vesa
2019-04-04 6:51 ` Aisheng Dong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB422278BD9C029E7332BB3C0A80500@VI1PR04MB4222.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).