From: Claudiu Manoil <claudiu.manoil@nxp.com>
To: Daniel Walker <danielwa@cisco.com>
Cc: Sathish Jarugumalli <sjarugum@cisco.com>,
"xe-linux-external@cisco.com" <xe-linux-external@cisco.com>,
Daniel Walker <dwalker@fifo99.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drivers: net: gianfar: Shortest frame drops at Ethernet port
Date: Wed, 6 Nov 2019 17:38:06 +0000 [thread overview]
Message-ID: <VI1PR04MB4880B060847C1CD175B998DF96790@VI1PR04MB4880.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191106170320.27662-1-danielwa@cisco.com>
>-----Original Message-----
>From: Daniel Walker <danielwa@cisco.com>
>Sent: Wednesday, November 6, 2019 7:03 PM
>To: Claudiu Manoil <claudiu.manoil@nxp.com>
>Cc: Sathish Jarugumalli <sjarugum@cisco.com>; xe-linux-external@cisco.com;
>Daniel Walker <dwalker@fifo99.com>; David S. Miller
><davem@davemloft.net>; netdev@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH] drivers: net: gianfar: Shortest frame drops at Ethernet port
>
>NXP has provided the patch for packet drops at ethernet port
>Frames shorter than 60bytes are getting dropped at ethernetport
>need to add padding for the shorter range frames to be transmit
>the function "eth_skb_pad(skb" provides padding (and CRC) for
>packets under 60 bytes
>
>Signed-off-by: Sathish Jarugumalli <sjarugum@cisco.com>
>Cc: xe-linux-external@cisco.com
>Signed-off-by: Daniel Walker <dwalker@fifo99.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Normally padding is done by the hardware, and it works at least on my
test cases and boards.
But cisco seems to have hit a case where h/w padding gets
unexpectedly disabled (concurrency issue writing the config register?).
This patch should go as a workaround, until root cause found.
-Claudiu
next prev parent reply other threads:[~2019-11-06 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 17:03 [PATCH] drivers: net: gianfar: Shortest frame drops at Ethernet port Daniel Walker
2019-11-06 17:38 ` Claudiu Manoil [this message]
2019-11-06 17:46 ` Daniel Walker
2019-11-07 23:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB4880B060847C1CD175B998DF96790@VI1PR04MB4880.eurprd04.prod.outlook.com \
--to=claudiu.manoil@nxp.com \
--cc=danielwa@cisco.com \
--cc=davem@davemloft.net \
--cc=dwalker@fifo99.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjarugum@cisco.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).